python-neutronclient

LBaaS: lb-healthmonitor-update works incorrectly

Bug #1245859 reported by Eugene Nikanorov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Medium
Eugene Nikanorov
python-neutronclient 2.3.0-2.3.4

Bug Description

Request such as http://ip:9696/v2.0/lb/health_monitors.json?fields=id&name=blabla returns all healthmonitors.

As a result, when using cli lb-healthmonitor-update and if there is just 1 monitor it gets updated even if its id was specified incorrectly.

See original description
Tags: lbaas
Eugene Nikanorov (enikanorov)
tags: added: lbaas
description: updated
description: updated
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

It appears to be an issue with neutron client that uses find_resourceid_by_name_or_id for healthmonitors which don't have name attribute

affects: neutron → python-neutronclient
Eugene Nikanorov (enikanorov)
summary: - LBaaS: list of healthmonitors is returned incorrectly
+ LBaaS: lb-healthmonitor-update works incorrectly
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/54529

Changed in python-neutronclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/54529
Committed: http://github.com/openstack/python-neutronclient/commit/ad64270c2534376916ecf729fbdc20c052d5e036
Submitter: Jenkins
Branch: master

commit ad64270c2534376916ecf729fbdc20c052d5e036
Author: Eugene Nikanorov <email address hidden>
Date: Wed Oct 30 16:01:03 2013 +0400

    Fix lb-healthmonitor-update to work with correct object

    Previously in case specified id was incorrect, client fetched
    healthmonitors trying to filter them by name which had no effect since
    healthmonitor object doesn't have name attribute.
    The patch fixes the behavior by making lb-healthmonitor-update rely
    on finding resource by id, not by name-or-id

    Change-Id: Iade1c3270ec6c60362dd9a9b5e2ffdb0ad9430c1
    Closes-Bug: #1245859

Changed in python-neutronclient:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 2.3.0-2.3.4
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.