[enhancement] Mir does not have any non-alpha pixel format on Nexus 4, preventing occlusion optimizations
Bug #1240833 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Alexandros Frantzis | ||
mir (Ubuntu) |
Fix Released
|
High
|
Unassigned |
Bug Description
The Nexus 4 presently only reports one supported pixel format to clients: ABGR. This works, but it means occlusion optimizations will never be used on that platform.
We need to expose or fake at least one non-alpha (XBGR?) pixel format, so that if clients choose that they can be composited more efficiently.
Related branches
lp://staging/~afrantzis/mir/surface-formats-for-real
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Approve
- Alan Griffiths: Approve
- Kevin DuBois (community): Approve
-
Diff: 507 lines (+77/-80)13 files modifiedinclude/test/mir_test_doubles/stub_display_configuration.h (+11/-4)
src/client/mir_client_library.cpp (+1/-1)
src/client/mir_connection.cpp (+6/-8)
src/client/mir_connection.h (+2/-2)
src/server/frontend/default_configuration.cpp (+2/-1)
src/server/frontend/session_mediator.cpp (+5/-3)
src/server/frontend/session_mediator.h (+4/-3)
src/shared/protobuf/mir_protobuf.proto (+6/-32)
tests/integration-tests/test_display_info.cpp (+11/-8)
tests/unit-tests/client/test_mir_connection.cpp (+15/-4)
tests/unit-tests/frontend/test_session_mediator.cpp (+7/-6)
tests/unit-tests/frontend/test_session_mediator_android.cpp (+3/-3)
tests/unit-tests/frontend/test_session_mediator_gbm.cpp (+4/-5)
tags: | added: nexus4 performance |
summary: |
- [feature] Expose at least one non-alpha pixel format for Nexus 4 + [enhancement] Expose at least one non-alpha pixel format for Nexus 4 |
tags: |
added: enhancement removed: feature |
summary: |
- [enhancement] Expose at least one non-alpha pixel format for Nexus 4 + [enhancement] Mir does not have any non-alpha pixel format on Nexus 4, + preventing occlusion optimizations |
Changed in mir: | |
importance: | Medium → High |
Changed in mir: | |
assignee: | nobody → Alexandros Frantzis (afrantzis) |
milestone: | none → 0.1.2 |
status: | Triaged → In Progress |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in mir (Ubuntu): | |
status: | Triaged → Fix Committed |
To post a comment you must log in.
Fix committed into lp:~mir-team/mir/development-branch at revision None, scheduled for release in mir, milestone Unknown