Ubuntu
qtbase-opensource-src package

[Patch] Fix rowsInserted not being emmited in some cases in QSortFilterProxyModel

Bug #1234603 reported by Albert Astals Cid
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
qtbase-opensource-src (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

There is a bug in QSortFilterProxyModel where sometimes it does not emit a rowsInserted if it happens just after a rowsMoved from the source model.

There is a patch upstream with a test that proves it is needed.

It is still waiting for review but we need it since otherwise some code of Ubuntu Touch does not work at all.

Attaching the patch (minus the test).

Related branches

lp://staging/~saviq/ubuntu/saucy/qtbase-opensource-src/add-proxymodel-patch
Ubuntu branches: Pending requested
Diff: 6723 lines (+6654/-2)
7 files modified
.pc/0001-Fix-rowsInserted-not-being-emmited-in-some-cases-in-.patch/src/corelib/itemmodels/qsortfilterproxymodel.cpp (+2767/-0)
.pc/0001-Fix-rowsInserted-not-being-emmited-in-some-cases-in-.patch/tests/auto/corelib/itemmodels/qsortfilterproxymodel/tst_qsortfilterproxymodel.cpp (+3640/-0)
.pc/applied-patches (+1/-0)
debian/patches/0001-Fix-rowsInserted-not-being-emmited-in-some-cases-in-.patch (+145/-0)
debian/patches/series (+1/-0)
src/corelib/itemmodels/qsortfilterproxymodel.cpp (+5/-2)
tests/auto/corelib/itemmodels/qsortfilterproxymodel/tst_qsortfilterproxymodel.cpp (+95/-0)
lp://staging/~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src_5.0.2
lp://staging/ubuntu/trusty/qtbase-opensource-src
Revision history for this message
Albert Astals Cid (aacid) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in qtbase-opensource-src (Ubuntu):
status: New → Confirmed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Please test a built package from ppa:canonical-qt5-edgers/qt5-daily (make sure you get updates to version 5.0.2+dfsg1-7ubuntu10~saucy1~test1) and give feedback. Then add it to Landing Asks page in the landing google doc saying that it's included in the packaging branch and ready to land.

Revision history for this message
Albert Astals Cid (aacid) wrote :

I can confirm that the code at https://code.launchpad.net/~stolowski/unity8/category-reordering works with this patch while previously it did not.

I'll ask Pawel to try and report back.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

I did some testing with my branch and it now works fine with the above version of Qt5. Thank you!

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Thanks for testing! I added it to the Landing Pipeline doc.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtbase-opensource-src - 5.0.2+dfsg1-7ubuntu10

---------------
qtbase-opensource-src (5.0.2+dfsg1-7ubuntu10) saucy; urgency=low

  * debian/patches/fix_rowinserted.patch:
    - Fix a bug in QSortFilterProxyModel by picking a patch
      from upstream (LP: #1234603)
 -- Timo Jyrinki <email address hidden> Thu, 03 Oct 2013 12:58:40 +0300

Changed in qtbase-opensource-src (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.