Remove neutron resources id attributes

Bug #1230228 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Thomas Herve

Bug Description

As we discovered with CinderVolume, using Fn::GetAtt with id attributes can create problems at validations as the volume resource_id is empty. As those map to Ref, we should remove id from the attributes to not encourage its usage.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48230

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48233

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48237

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48239

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48240

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48242

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48243

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/48230
Committed: http://github.com/openstack/heat/commit/1983e0767426b9346c6bdc9b3c698d43b3290928
Submitter: Jenkins
Branch: master

commit 1983e0767426b9346c6bdc9b3c698d43b3290928
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:27:57 2013 +0200

    Remove Net resource id attribute

    This patch removes the 'id' attribute of Net resource to encourage Ref
    usage, and fixes some attribute description.

    Partial-Bug: #1230228
    Change-Id: I1674e67f6c20007ef809db8e16a707922e5cda1c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/48233
Committed: http://github.com/openstack/heat/commit/14a6a98ab2cc710d3255e0ae842a50b01fbe38ce
Submitter: Jenkins
Branch: master

commit 14a6a98ab2cc710d3255e0ae842a50b01fbe38ce
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:31:57 2013 +0200

    Remove Neutron load balancer resources id attributes

    This patch removes id attributes from Pool and HealthMonitor as people
    should use Ref instead.

    Partial-Bug: #1230228
    Change-Id: I92d74fcaa2a5443cb38bc647056d4fc7a95677a0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/48237
Committed: http://github.com/openstack/heat/commit/fd21e5edf26c638559a7be46a3a92b712b66962b
Submitter: Jenkins
Branch: master

commit fd21e5edf26c638559a7be46a3a92b712b66962b
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:38:36 2013 +0200

    Remove Neutron firewall resources id attributes

    This patch removes the id attributes of the various firewall resources,
    and fixes attribute description to use gettext and proper sentences.

    Change-Id: I4ccbb86239cd904a1b8f7023abe92842762429f2
    Partial-Bug: #1230228

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/48239
Committed: http://github.com/openstack/heat/commit/77348fdbff921205b792475cdec369cd01dbfd73
Submitter: Jenkins
Branch: master

commit 77348fdbff921205b792475cdec369cd01dbfd73
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:42:22 2013 +0200

    Remove Port resource id attribute

    This patch removes the id attribute of the Neutron Port resource, as
    people should use Ref.

    Change-Id: I7acf1564ff4c25c8cbac53cd58bf93195352b451
    Partial-Bug: #1230228

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/48240
Committed: http://github.com/openstack/heat/commit/9819c059ee13a945eef659b4aaf65cda0d164b0a
Submitter: Jenkins
Branch: master

commit 9819c059ee13a945eef659b4aaf65cda0d164b0a
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:43:46 2013 +0200

    Remove Router resource id attribute

    This patch removes Neutron Router id attribute, and apply gettext to the
    attribute descriptions.

    Partial-Bug: #1230228
    Change-Id: I91b6500c15a3b231296bb7bb0598a11819fe6981

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/48242
Committed: http://github.com/openstack/heat/commit/7a82df133da580c16cc864415b2f295e8e9d8fde
Submitter: Jenkins
Branch: master

commit 7a82df133da580c16cc864415b2f295e8e9d8fde
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:47:04 2013 +0200

    Remove Subnet id attribute

    This patch removes the Neutron Subnet id attribute, and apply gettext to
    the attributes descriptions.

    Change-Id: I0b5f60d59dcde336ca7d67fb8fe8a527426dac98
    Partial-Bug: #1230228

Revision history for this message
Faramir (faramir) wrote : AUTO: Hai Liang Wang is on vacation from 09-29 to 10-08 (returning 10/09/2013)

I am out of the office until 10/09/2013.

Conact me by phone for anything urgency.
Phone Number - 15801213126 . thanks !

Note: This is an automated response to your message "[Bug 1230228] Fix
merged to heat (master)" sent on 09/28/2013 19:13:33.

This is the only notification you will receive while this person is away.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/48243
Committed: http://github.com/openstack/heat/commit/393e29d9dc58a9780c48ec741dbe262fb471d9a6
Submitter: Jenkins
Branch: master

commit 393e29d9dc58a9780c48ec741dbe262fb471d9a6
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 14:49:49 2013 +0200

    Remove Neutron VPN resources id attributes

    This patch removes the id attributes from the various Neutron VPN
    resources, as people should use Ref.

    Change-Id: Idf81d109b930b246791a0f3c22bc04ce5054b939
    Closes-Bug: #1230228

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.