Ubuntu
gnome-desktop package

ubuntu applies an erroneous patch to gnome-desktop

Bug #123022 reported by Christian Neumair
2
Affects Status Importance Assigned to Milestone
gnome-desktop (Ubuntu)
Fix Released
High
Ubuntu Desktop Bugs

Bug Description

The patch 01_desktopfile_gettext.patch is broken. For empty keys, it calls dgettext (domain, "") which will dump the gettext .po file and causes

http://bugzilla.gnome.org/show_bug.cgi?id=439529

Revision history for this message
Christian Neumair (chris-gnome-de) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for the patch!

Changed in gnome-desktop:
assignee: nobody → desktop-bugs
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Christian Neumair (chris-gnome-de) wrote :

Before I forget it: Maybe you also have to check for value being NULL, it's abit more safe, i.e.

if (value != NULL && value[0] != '\0')

may also be appropriate

Revision history for this message
Sebastien Bacher (seb128) wrote :

gnome-desktop (1:2.19.4-0ubuntu2) gutsy; urgency=low

  * debian/patches/01_desktopfile_gettext.patch:
    - don't call gettext when the string is "", patch by Christian Neumair
      (LP: #123022)

 -- Sebastien Bacher <email address hidden> Fri, 29 Jun 2007 13:49:13 +0200

Changed in gnome-desktop:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.