Mir

acceptance-tests FAIL: TestClientInput.hidden_clients_do_not_receive_pointer_events

Bug #1227683 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Robert Carr
Mir 0.1.1
mir (Ubuntu)
Fix Released
High
Unassigned

Bug Description

valgrind acceptance-tests FAIL: TestClientInput.hidden_clients_do_not_receive_pointer_events

[ RUN ] TestClientInput.hidden_clients_do_not_receive_pointer_events
/home/dan/bzr/mir/trunk/tests/acceptance-tests/test_client_input.cpp:916: Failure
Actual function call count doesn't match EXPECT_CALL(*handler, handle_input(MotionEventWithPosition(2, 2)))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
Google Test trace:
/home/dan/bzr/mir/trunk/tests/mir_test_framework/testing_process_manager.cpp:110: Client
==23634==
==23634== HEAP SUMMARY:
==23634== in use at exit: 7,179 bytes in 125 blocks
==23634== total heap usage: 22,473 allocs, 22,348 frees, 1,574,144 bytes allocated
==23634==
==23634== LEAK SUMMARY:
==23634== definitely lost: 0 bytes in 0 blocks
==23634== indirectly lost: 0 bytes in 0 blocks
==23634== possibly lost: 2,787 bytes in 45 blocks
==23634== still reachable: 4,392 bytes in 80 blocks
==23634== suppressed: 0 bytes in 0 blocks
==23634== Rerun with --leak-check=full to see details of leaked memory
==23634==
==23634== For counts of detected and suppressed errors, rerun with: -v
==23634== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
/home/dan/bzr/mir/trunk/tests/mir_test_framework/testing_process_manager.cpp:127: Failure
Value of: result.succeeded()
  Actual: false
Expected: true
client terminate error=process::Result(child_terminated_normally, failure(1))
==23635==
==23635== HEAP SUMMARY:
==23635== in use at exit: 7,171 bytes in 124 blocks
==23635== total heap usage: 22,469 allocs, 22,345 frees, 1,580,777 bytes allocated
==23635==
==23635== LEAK SUMMARY:
==23635== definitely lost: 0 bytes in 0 blocks
==23635== indirectly lost: 0 bytes in 0 blocks
==23635== possibly lost: 2,787 bytes in 45 blocks
==23635== still reachable: 4,384 bytes in 79 blocks
==23635== suppressed: 0 bytes in 0 blocks
==23635== Rerun with --leak-check=full to see details of leaked memory
==23635==
==23635== For counts of detected and suppressed errors, rerun with: -v
==23635== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
==23632==
==23632== HEAP SUMMARY:
==23632== in use at exit: 310 bytes in 7 blocks
==23632== total heap usage: 12,764 allocs, 12,757 frees, 824,254 bytes allocated
==23632==
==23632== LEAK SUMMARY:
==23632== definitely lost: 0 bytes in 0 blocks
==23632== indirectly lost: 0 bytes in 0 blocks
==23632== possibly lost: 118 bytes in 4 blocks
==23632== still reachable: 192 bytes in 3 blocks
==23632== suppressed: 0 bytes in 0 blocks
==23632== Rerun with --leak-check=full to see details of leaked memory
==23632==
==23632== For counts of detected and suppressed errors, rerun with: -v
==23632== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
[ FAILED ] TestClientInput.hidden_clients_do_not_receive_pointer_events (6312 ms)

Related branches

lp://staging/~robertcarr/mir/fix-1227683
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Kevin DuBois: Pending requested
Diff: 11 lines (+1/-1)
1 file modified
tests/acceptance-tests/test_client_input.cpp (+1/-1)
Superseded for merging into lp://staging/mir/0.1
Kevin DuBois (community): Needs Information
Daniel van Vugt: Needs Resubmitting
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 4407 lines (+1372/-678)
130 files modified
doc/component_reports.md (+2/-0)
examples/render_surfaces.cpp (+2/-0)
examples/render_to_fb.cpp (+1/-4)
include/client/mir_toolkit/mir_client_library_drm.h (+14/-0)
include/server/mir/compositor/buffer_stream.h (+5/-5)
include/server/mir/compositor/default_display_buffer_compositor_factory.h (+2/-0)
include/server/mir/compositor/scene.h (+2/-5)
include/server/mir/default_configuration_options.h (+2/-0)
include/server/mir/default_server_configuration.h (+5/-0)
include/server/mir/shell/session.h (+1/-0)
include/server/mir/surfaces/buffer_stream_factory.h (+3/-4)
include/server/mir/surfaces/surface.h (+8/-5)
include/server/mir/surfaces/surface_controller.h (+1/-1)
include/server/mir/surfaces/surfaces_report.h (+60/-0)
include/test/mir_test/draw/android_graphics.h (+1/-1)
include/test/mir_test_doubles/mock_buffer_stream.h (+2/-2)
include/test/mir_test_doubles/mock_shell_session.h (+2/-0)
include/test/mir_test_doubles/mock_surface_renderer.h (+4/-3)
include/test/mir_test_doubles/stub_buffer_stream.h (+2/-2)
include/test/mir_test_doubles/stub_ipc_factory.h (+2/-2)
include/test/mir_test_doubles/stub_shell_session.h (+4/-0)
include/test/mir_test_doubles/stub_surface_builder.h (+8/-2)
src/client/mir_client_library.cpp (+29/-8)
src/client/mir_connection.cpp (+16/-0)
src/client/mir_connection.h (+4/-0)
src/platform/graphics/CMakeLists.txt (+0/-1)
src/server/CMakeLists.txt (+1/-0)
src/server/compositor/CMakeLists.txt (+1/-0)
src/server/compositor/buffer_stream_factory.cpp (+3/-3)
src/server/compositor/buffer_stream_factory.h (+1/-1)
src/server/compositor/buffer_stream_surfaces.cpp (+1/-1)
src/server/compositor/buffer_stream_surfaces.h (+2/-2)
src/server/compositor/bypass.cpp (+2/-2)
src/server/compositor/bypass.h (+3/-3)
src/server/compositor/default_configuration.cpp (+85/-0)
src/server/compositor/default_display_buffer_compositor.cpp (+3/-3)
src/server/compositor/default_display_buffer_compositor_factory.cpp (+2/-2)
src/server/compositor/gl_renderer.cpp (+2/-2)
src/server/compositor/gl_renderer.h (+2/-2)
src/server/compositor/gl_renderer_factory.cpp (+1/-1)
src/server/compositor/gl_renderer_factory.h (+1/-1)
src/server/compositor/multi_threaded_compositor.cpp (+1/-1)
src/server/compositor/occlusion.cpp (+1/-1)
src/server/compositor/occlusion.h (+1/-1)
src/server/compositor/renderer.h (+2/-5)
src/server/compositor/rendering_operator.cpp (+2/-3)
src/server/compositor/rendering_operator.h (+2/-2)
src/server/default_configuration_options.cpp (+6/-0)
src/server/default_server_configuration.cpp (+3/-399)
src/server/frontend/default_configuration.cpp (+99/-2)
src/server/frontend/global_event_sender.cpp (+1/-1)
src/server/frontend/global_event_sender.h (+1/-1)
src/server/frontend/protobuf_message_processor.cpp (+1/-1)
src/server/frontend/protobuf_session_creator.cpp (+1/-1)
src/server/frontend/resource_cache.cpp (+1/-1)
src/server/frontend/session_mediator.cpp (+3/-3)
src/server/frontend/session_mediator_android.cpp (+1/-1)
src/server/frontend/session_mediator_gbm.cpp (+1/-1)
src/server/graphics/CMakeLists.txt (+7/-0)
src/server/graphics/default_configuration.cpp (+147/-0)
src/server/graphics/default_display_configuration_policy.cpp (+6/-6)
src/server/graphics/default_display_configuration_policy.h (+3/-6)
src/server/graphics/nested/host_connection.cpp (+3/-3)
src/server/graphics/nested/host_connection.h (+1/-1)
src/server/graphics/nested/nested_display.cpp (+1/-1)
src/server/graphics/nested/nested_platform.cpp (+2/-2)
src/server/graphics/nested/nested_platform.h (+1/-1)
src/server/logging/CMakeLists.txt (+2/-0)
src/server/logging/connector_report.cpp (+1/-1)
src/server/logging/default_configuration.cpp (+112/-0)
src/server/logging/display_report.cpp (+1/-1)
src/server/logging/session_mediator_report.cpp (+1/-1)
src/server/logging/surfaces_report.cpp (+119/-0)
src/server/logging/surfaces_report.h (+56/-0)
src/server/surfaces/CMakeLists.txt (+2/-0)
src/server/surfaces/default_configuration.cpp (+99/-0)
src/server/surfaces/surface.cpp (+14/-8)
src/server/surfaces/surface_allocator.cpp (+8/-6)
src/server/surfaces/surface_allocator.h (+5/-2)
src/server/surfaces/surface_controller.cpp (+1/-1)
src/server/surfaces/surface_stack.cpp (+21/-11)
src/server/surfaces/surface_stack.h (+6/-2)
src/server/surfaces/surfaces_report.cpp (+27/-0)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_input.cpp (+2/-2)
tests/acceptance-tests/test_client_library_drm.cpp (+59/-0)
tests/acceptance-tests/test_display_configuration.cpp (+1/-1)
tests/acceptance-tests/test_server_shutdown.cpp (+3/-3)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+1/-1)
tests/integration-tests/compositor/test_buffer_stream.cpp (+4/-5)
tests/integration-tests/compositor/test_swapping_swappers.cpp (+1/-1)
tests/integration-tests/graphics/android/test_internal_client.cpp (+7/-5)
tests/integration-tests/graphics/gbm/test_buffer_integration.cpp (+1/-1)
tests/integration-tests/shell/test_session.cpp (+4/-4)
tests/integration-tests/shell/test_session_manager.cpp (+1/-1)
tests/integration-tests/test_display_info.cpp (+4/-4)
tests/integration-tests/test_error_reporting.cpp (+2/-2)
tests/integration-tests/test_surface_first_frame_sync.cpp (+3/-3)
tests/integration-tests/test_swapinterval.cpp (+4/-4)
tests/mir_test_framework/testing_server_options.cpp (+3/-3)
tests/unit-tests/client/test_client_mir_surface.cpp (+1/-1)
tests/unit-tests/client/test_mir_connection.cpp (+48/-1)
tests/unit-tests/compositor/test_buffer_stream.cpp (+1/-2)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+4/-4)
tests/unit-tests/compositor/test_gl_renderer.cpp (+3/-3)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+1/-1)
tests/unit-tests/compositor/test_rendering_operator.cpp (+2/-3)
tests/unit-tests/frontend/stress_protobuf_communicator.cpp (+1/-1)
tests/unit-tests/frontend/test_global_event_sender.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_reports_errors.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_sends_fds.cpp (+1/-1)
tests/unit-tests/frontend/test_protobuf_surface_apis.cpp (+1/-1)
tests/unit-tests/frontend/test_published_socket_connector.cpp (+1/-1)
tests/unit-tests/frontend/test_resource_cache.cpp (+1/-1)
tests/unit-tests/frontend/test_session_mediator.cpp (+3/-3)
tests/unit-tests/frontend/test_session_mediator_android.cpp (+2/-2)
tests/unit-tests/frontend/test_session_mediator_gbm.cpp (+2/-2)
tests/unit-tests/graphics/gbm/test_gbm_display.cpp (+2/-2)
tests/unit-tests/graphics/gbm/test_gbm_display_configuration.cpp (+1/-1)
tests/unit-tests/graphics/gbm/test_gbm_display_multi_monitor.cpp (+1/-1)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+1/-1)
tests/unit-tests/graphics/test_display.cpp (+1/-1)
tests/unit-tests/input/android/test_android_input_lexicon.cpp (+14/-0)
tests/unit-tests/logging/test_display_report.cpp (+1/-1)
tests/unit-tests/shell/test_session_manager.cpp (+1/-1)
tests/unit-tests/shell/test_surface.cpp (+8/-2)
tests/unit-tests/surfaces/test_surface.cpp (+20/-18)
tests/unit-tests/surfaces/test_surface_allocator.cpp (+1/-1)
tests/unit-tests/surfaces/test_surface_controller.cpp (+1/-1)
tests/unit-tests/surfaces/test_surface_stack.cpp (+80/-34)
lp://staging/ubuntu/trusty-proposed/mir
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks like bug 1212518 wasn't really fixed.

Changed in mir:
importance: Undecided → High
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Download full text (3.3 KiB)

More detailed logging...

[ RUN ] TestClientInput.hidden_clients_do_not_receive_pointer_events
[II, android-input] Device added: id=0, name='', sources=0x00000101
[II, android-input] Device added: id=1, name='', sources=0x00002002
[II, input] Published motion event (seq_id, event_time) to fd 28: (1, 1379689387423953762)
[II, input] Published motion event (seq_id, event_time) to fd 28: (2, 1379689387423953762)
/home/dan/bzr/mir/trunk/tests/acceptance-tests/test_client_input.cpp:916: Failure
Actual function call count doesn't match EXPECT_CALL(*handler, handle_input(MotionEventWithPosition(2, 2)))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
Google Test trace:
/home/dan/bzr/mir/trunk/tests/mir_test_framework/testing_process_manager.cpp:110: Client
[II, input] Received event finished (seq_id) from fd 28: 1
[II, input] Received event finished (seq_id) from fd 28: 2
[II, android-input] Dropping event because there is no touched window.
==17535==
==17535== HEAP SUMMARY:
==17535== in use at exit: 7,179 bytes in 125 blocks
==17535== total heap usage: 22,590 allocs, 22,465 frees, 1,578,420 bytes allocated
==17535==
==17535== LEAK SUMMARY:
==17535== definitely lost: 0 bytes in 0 blocks
==17535== indirectly lost: 0 bytes in 0 blocks
==17535== possibly lost: 2,787 bytes in 45 blocks
==17535== still reachable: 4,392 bytes in 80 blocks
==17535== suppressed: 0 bytes in 0 blocks
==17535== Rerun with --leak-check=full to see details of leaked memory
==17535==
==17535== For counts of detected and suppressed errors, rerun with: -v
==17535== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
/home/dan/bzr/mir/trunk/tests/mir_test_framework/testing_process_manager.cpp:127: Failure
Value of: result.succeeded()
  Actual: false
Expected: true
client terminate error=process::Result(child_terminated_normally, failure(1))
==17536==
==17536== HEAP SUMMARY:
==17536== in use at exit: 7,171 bytes in 124 blocks
==17536== total heap usage: 22,586 allocs, 22,462 frees, 1,585,053 bytes allocated
==17536==
==17536== LEAK SUMMARY:
==17536== definitely lost: 0 bytes in 0 blocks
==17536== indirectly lost: 0 bytes in 0 blocks
==17536== possibly lost: 2,787 bytes in 45 blocks
==17536== still reachable: 4,384 bytes in 79 blocks
==17536== suppressed: 0 bytes in 0 blocks
==17536== Rerun with --leak-check=full to see details of leaked memory
==17536==
==17536== For counts of detected and suppressed errors, rerun with: -v
==17536== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
==17533==
==17533== HEAP SUMMARY:
==17533== in use at exit: 310 bytes in 7 blocks
==17533== total heap usage: 12,958 allocs, 12,951 frees, 833,618 bytes allocated
==17533==
==17533== LEAK SUMMARY:
==17533== definitely lost: 0 bytes in 0 blocks
==17533== indirectly lost: 0 bytes in 0 blocks
==17533== possibly lost: 118 bytes in 4 blocks
==17533== still reachable: 192 bytes in 3 blocks
==17533== suppressed: 0 bytes in 0 blocks
==17533== Rerun with --leak-check=full to see details of leaked memory
==17533==
==17533== For counts of detected an...

Read more...

Changed in mir:
assignee: nobody → Robert Carr (robertcarr)
Revision history for this message
kevin gunn (kgunn72) wrote :

ended up being jenkins shennanigans.
solution - Francis Ginther is awesome!...he provisioned 2 dedicated build/ci hosts which has solved this problem

Changed in mir:
status: New → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Nothing is fixed. It's happening on my laptop.

Changed in mir:
status: Fix Released → Triaged
assignee: Robert Carr (robertcarr) → nobody
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Verified the bug still happens with development-branch r1094.

Daniel van Vugt (vanvugt)
tags: added: testsfail
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Still happening: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-saucy-amd64-ci/231/console

Chris Gagnon (chris.gagnon)
tags: added: qa-touch
Robert Carr (robertcarr)
Changed in mir:
status: Triaged → In Progress
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Robert Carr (robertcarr)
milestone: none → 0.1.1
Daniel van Vugt (vanvugt)
summary: - valgrind acceptance-tests FAIL:
+ acceptance-tests FAIL:
TestClientInput.hidden_clients_do_not_receive_pointer_events
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:~mir-team/mir/development-branch at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Changed in mir (Ubuntu):
status: New → Triaged
importance: Undecided → High
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.1.1+14.04.20131120-0ubuntu1

---------------
mir (0.1.1+14.04.20131120-0ubuntu1) trusty; urgency=low

  [ Daniel van Vugt ]
  * New upstream release 0.1.1
    - Add unit tests for V/H scroll events.
    - surfaces: avoid publishing some internal headers, tidy up default
      configuration, integrate surfaces report.
    - client: Add mir_connection_drm_set_gbm_device()
    - graphics: avoid publishing some internal headers.
    - Fixed: unity-system-compositor FTBFS on trusty against new Mir
      (libmirserver9) (LP: #1244192)
    - compositor: avoid publishing some internal headers.
    - shell: Add set_lifecycle_state() to the Session interface.
    - frontend: avoid publishing some internal headers
    - logging: avoid publishing some internal headers.
    - Allow specifying the nested server name by passing --name= or setting
      MIR_SERVER_NAME=.
    - graphics,gbm: Inform the EGL platform about the used gbm device when
      using the native GBM platform
    - examples: Restore GL state after initializing buffers, fixing crashes
      observed in render_surfaces (LP: #1234563)
    - Continue refactoring the mir android display classes.
    - shell: Hoist focus control functions needed by unity-mir into
      FocusController interface
    - client: Remove the timeout for detecting server crashes
    - Avoid a race condition that could lead to spurious failures of server
      shutdown tests (LP: #1245336)
    - test_client_input.cpp: Bump reception time-out in client test fixture.
      (LP: #1227683)
    - Ensure StubBufferAllocator returns buffers with the properties requested,
      and not the same old hardcoded constants.
    - Update docs and scripting for trusty.
    - compositor: Make DefaultDisplayBufferCompositorFactory private to the
      compositor component.
    - Ignore warnings clang treats as errors, about unused functions being
      generated from macros in <lttng/tracepoint.h> (LP: #1246590)
    - Add resize() support to BufferBundle. This is the first step and lowest
      level of surface resize support.
    - Clean up constants relating to SwitchingBundle.
    - Fix the armhf chroot setup script to point to the right library, so
      cross compiling can work again (LP: #1246975)
    - shell: avoid publishing some internal headers.
    - input: avoid publishing some internal headers.
  * Bump timeouts used in socket testing. It seems 100ms isn't always
    enough, which leads to spurious test failures (LP: #1252144) (LP:
    #1252144)
  * Fix uninitialized variable causing random drm_auth_magic test
    failures. (LP: #1252144). (LP: #1252144)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 1165
 -- Ubuntu daily release <email address hidden> Wed, 20 Nov 2013 07:36:15 +0000

Changed in mir (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.