[PATCH] memory leak + error handling glitch in gnome-keyring-proto.c:gnome_keyring_proto_decode_find_reply

Bug #122502 reported by Alexander Sack
2
Affects Status Importance Assigned to Milestone
GNOME Keyring
Fix Released
High
gnome-keyring (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: gnome-keyring

while looking into bug 121228 i found this wrong looking code. Please review the attached patch.

Revision history for this message
Alexander Sack (asac) wrote :

here the patch ...

Changed in gnome-keyring:
assignee: nobody → desktop-bugs
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Alex, I prepared, uploaded, and tested a new package. I didn't accept it for tribe-2 though, since it does not fix bug #122385 after all.

Changed in gnome-keyring:
assignee: desktop-bugs → pitti
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

gnome-keyring (2.19.4.1-0ubuntu2) gutsy; urgency=low

  * Add debian/patches/error_handling.patch:
    - Fix broken error handling and memory leak in
      gnome_keyring_proto_decode_find_reply().
    - Thanks to Alexander Sack for this patch!
    - LP: #122502

 -- Martin Pitt <email address hidden> Wed, 27 Jun 2007 11:52:01 +0200

Changed in gnome-keyring:
status: Fix Committed → Fix Released
Changed in gnome-keyring:
status: Unknown → Fix Released
Changed in gnome-keyring:
importance: Unknown → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.