neutron

vm_id tag may be confusing for nvp logical port

Bug #1215204 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Armando Migliaccio
neutron 2013.2 "havana"

Bug Description

The NVP plugin records the following tags for a logical port:

- q_port_id: Neutron port uuid
- quantum: Neutron version
- os_tid: OpenStack tenant uuid
- vm_id: a hash of the device_id

It should be more appropriate to change the tag name from vm_id to dev_id_hash, or to use the actual Nova VM uuid, otherwise things can be confusing.

Granted the NVP admin should not care about those tags, but most times, an NVP admin is also an OpenStack admin, so his/her eye may be trained to see these things and raise an issue that doesn't actually exist.

Tags: nicira
Armando Migliaccio (armando-migliaccio)
tags: added: nicira
removed: nec
Changed in neutron:
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43218

Changed in neutron:
status: New → In Progress
Mark McClain (markmcclain)
Changed in neutron:
milestone: none → havana-rc1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/43218
Committed: http://github.com/openstack/neutron/commit/edd17eae6ab9101f8d780ced3b01b8eec8c663e1
Submitter: Jenkins
Branch: master

commit edd17eae6ab9101f8d780ced3b01b8eec8c663e1
Author: armando-migliaccio <email address hidden>
Date: Wed Aug 21 17:51:34 2013 -0700

    Hash device_id only if it is longer than the allowed MAX size for NVP

    This ensure that a VM uuid stays untouched, avoiding potential
    confusion when inspecting NVP port tags. This patch also abstracts
    the hashing method out by introducing a device_id_to_vm_id method.
    Filtering logic is preserved, and a test has been added to ensure
    that. However such a logic is not currently used in the NeutronPlugin
    (because of the introduction of async status updates), but it has
    been added as utility method to nvplib.

    Fixes bug #1215204

    Change-Id: Ib96ecae438e30f195c8b45176abc1cf55b4b363f

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.