OpenStack Heat

InstanceGroup.resize may leave nested stack in FAILED status

Bug #1214007 reported by Liang Chen on 2013-08-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Heat	Fix Released	High	Christopher Armstrong	OpenStack Heat 2013.2 "havana"

Bug Description

InstanceGroup.resize removes FAILED instances after a nested stack update. But the nested stack will be in FAILED status in case a resource creation fails, the next update to the nested stack will be rejected.

Revision history for this message

Steven Hardy (shardy) wrote on 2013-08-21:

If this happens, I think we just have to set the InstanceGroup resource to a failed state, I guess UPDATE_FAILED

Changed in heat:
milestone:	none → havana-3
status:	New → Triaged
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-22: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43378

Changed in heat:
assignee:	nobody → Christopher Armstrong (radix)
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-26:

Fix proposed to branch: master
Review: https://review.openstack.org/43744

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-27: Fix merged to heat (master)

Reviewed: https://review.openstack.org/43744
Committed: http://github.com/openstack/heat/commit/fe498a2d4f97287cffe60a02d27a5e4b2665862d
Submitter: Jenkins
Branch: master

commit fe498a2d4f97287cffe60a02d27a5e4b2665862d
Author: Christopher Armstrong <email address hidden>
Date: Mon Aug 26 12:52:53 2013 -0500

Don't delete failed instances in InstanceGroup

    This gets rid of the code to delete failed instances in
    InstanceGroup so that administrators can debug what happened
    if any instances fail to start. It also allows the resize operation
    to raise an error, so the InstanceGroup should be in a FAILED state
    after a failed resize operation.

fixes bug 1214007
fixes bug 1215140

Change-Id: Id508195c847f09dd986e450f35876ff574ff7673