Ubuntu
open-vm-tools package

open-vm-tools-2013.04.16-1098359 dkms module does not build on linux-3.11

Bug #1208011 reported by Chris J Arges on 2013-08-03

14

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Linux Mint	New	Undecided	Unassigned
	open-vm-tools (Ubuntu)	Fix Released	Medium	Unassigned

Bug Description

open-vm-tools-2013.04.16-1098359 dkms module does not build on linux-3.11.
It will be important this works on 3.11 since Saucy will be rebased on 3.11 eventually.

The following errors occur:
1)
open-vm-tools-2013.04.16-1098359/modules/linux/vmhgfs/file.c: In function ‘HgfsAioRead’:
open-vm-tools-2013.04.16-1098359/modules/linux/vmhgfs/file.c:754:32: error: dereferencing pointer to incomplete type
    result = HgfsRevalidate(iocb->ki_filp->f_dentry);
                                ^
open-vm-tools-2013.04.16-1098359/modules/linux/vmhgfs/file.c: In function ‘HgfsAioWrite’:
open-vm-tools-2013.04.16-1098359/modules/linux/vmhgfs/file.c:803:32: error: dereferencing pointer to incomplete type
    result = HgfsRevalidate(iocb->ki_filp->f_dentry);
                                ^

This can be fixed with the patch in the following issue:
http://sourceforge.net/p/open-vm-tools/tracker/173/
https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1194940

Which adds the following to vmhgfs/file.c
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 10, 0)
+#include <linux/aio.h>
+#endif

2)
open-vm-tools-2013.04.16-1098359/modules/linux/vmhgfs/dir.c:82:4: error: unknown field ‘readdir’ specified in initializer
.readdir = HgfsReaddir,
^

This is because readdir has been renamed to iterate as of commit bb6f619b3a49f940d7478112500da312d70866eb. HgfsReaddir needs to use the new iterate functions, and readdir needs to be replaced with iterate for kernel versions that iterate exists.

See original description

Related branches

lp://staging/~n-muench/ubuntu/saucy/open-vm-tools/open-vm-tools.april-update.part2 (Merged)

lp://staging/~n-muench/ubuntu/saucy/open-vm-tools/open-vm-tools.april-update.part2-merge

Ready for review for merging into lp://staging/ubuntu/saucy/open-vm-tools

Dimitri John Ledkov (community): Approve on 2013-10-03

lp://staging/ubuntu/saucy-proposed/open-vm-tools

Chris J Arges (arges) on 2013-08-03

description:

updated

Revision history for this message

Chris J Arges (arges) wrote on 2013-08-04:

#1

Reported on sourceforge: https://sourceforge.net/p/open-vm-tools/tracker/175/

Revision history for this message

Chris J Arges (arges) wrote on 2013-08-05:

#2

Hi. This is not a duplicate of bug 1194940. Essentially we need to make sure open-vm-tools works with 3.11 and there is an additional bug introduced because of 'readdir' transitioning to 'iterate'. So both are issues for 3.11, and the other bug just affects 3.10.

Revision history for this message

Nate Muench (Mink) (n-muench) wrote on 2013-08-05:

#3

The truth is I would love to make a merge proposal (I could actually). But I'm honestly waiting for a new upstream release. I add this to everything.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-09-30:

#4

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in open-vm-tools (Ubuntu):
status:	New → Confirmed

Dimitri John Ledkov (xnox) on 2013-10-03

Changed in open-vm-tools (Ubuntu):
status:	Confirmed → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-10-03:

#5

This bug was fixed in the package open-vm-tools - 2013.04.16-1098359-0ubuntu2

---------------
open-vm-tools (2013.04.16-1098359-0ubuntu2) saucy-proposed; urgency=low

  * FFe LP: #1231148
  * Ubuntu-specific Changes
    - debian/rules: Removed Wno-error=unused-local-typedefs from CLFAGS.
      + We now enforce building with GCC 4.7.

- debian/patches: Add 0005-linux-310-fix.patch & 0006-linux-311-fix.patch
+ Fixes building against Saucy Kernels. (LP: #1194940, LP: #1208011)

    - debian/patches: Add 0007-dkms-supress-error.patch
      + Don't build modules that are broken, so modules that do build
        are available to be loaded.
      + Will be removed after next upstream release.

  * Items merged from Debian experimental:
    (From 2:9.2.2-893683-7 release)
    - Removing purely cosmetical 'sleep 1' leftover in initscript.

    (From 2:9.2.3-1031360-2 release)
    - Renaming debian-specific open-vm-toolbox package to open-vm-tools-
      desktop for consistency with upstream.
    - Revamping package descriptions.
    - Renaming open-vm-dkms to open-vm-tools-dkms for consistent package
      namespace.

(From 2:9.2.3-1031360-3 release)
- Adding initial systemd service file from fedora.

    (From 2:9.2.3-1031360-4 release)
    - Dropping kfreebsd from architecture list, it has never built and
      nobody seems willing to make it work (neither upstream, porters, nor
      users).

    (From 2:9.2.3-1031360-6 release)
    - Correcting syntax of file entries in copyright.
    - Adding section override for open-vm-tools-dkms.
    - Enforcing build with gcc 4.7 for the time being.
-- Nate Muench <email address hidden> Sat, 07 Sep 2013 20:50:33 -0500

Changed in open-vm-tools (Ubuntu):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Related blueprints

Plans for the open-vm-tools package during the 13.10 cycle

Remote bug watches

Bug watches keep track of this bug in other bug trackers.