OpenStack Object Storage (swift)

Obj-auditor fails when object_post_as_copy set to false

Bug #1206740 reported by Zhou Yuan on 2013-07-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Object Storage (swift)	Fix Released	Undecided	clayg	OpenStack Object Storage (swift) 1.9.1

Bug Description

1. set object_post_as_copy = false in proxy-server.conf

2. post a metadata on one object

swift post -m M1:V1 container obj

3. object-auditor fails to audit this object

object-auditor ERROR Trying to audit /opt/stack/data/swift/1/sdb1/objects/31/515/0feedae5ff8b420d3d24284a79056515/1375163235.14891.data: #012Traceback (most recent call last):#012 File "/opt/stack/swift/swift/obj/auditor.py", line 170, in object_audit#012 keep_data_fp=True)#012 File "/opt/stack/swift/swift/obj/diskfile.py", line 224, in __init__#012 if key.lower() not in self.disallowed_metadata_keys:#012TypeError: argument of type 'NoneType' is not iterable

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-07-31: Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/39410

Changed in swift:
assignee:	nobody → Kun Huang (academicgareth)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2013-07-31

Changed in swift:
assignee:	Kun Huang (academicgareth) → clayg (clay-gerrard)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-01: Fix merged to swift (master)

Reviewed: https://review.openstack.org/39410
Committed: http://github.com/openstack/swift/commit/6c3619469264d7dff05838fb632c546289df4e6e
Submitter: Jenkins
Branch: master

commit 6c3619469264d7dff05838fb632c546289df4e6e
Author: Kun Huang <email address hidden>
Date: Wed Jul 31 11:50:06 2013 +0800

give value [] if disallowed_metadata_keys is None

    The default value of DiskFile.disallowed_metadata_keys is None. And it
    will be iter in following codes even if it didn't get a new value. So
    it is necessary to give Diskfile.disallowed_metadata_keys an empty list
    in __init__ if the default value None is used.

fixes bug #1206740

Change-Id: I8454eba47b2c691166924356ab33b0235a800951

Changed in swift:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2013-08-07

Changed in swift:
milestone:	none → 1.9.1
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-12: Fix proposed to swift (feature/ec)

Fix proposed to branch: feature/ec
Review: https://review.openstack.org/41478

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-12: Fix merged to swift (feature/ec)

Download full text (8.4 KiB)

Reviewed: https://review.openstack.org/41478
Committed: http://github.com/openstack/swift/commit/6fff883838b823335f4f4104113112a47e4a5a30
Submitter: Jenkins
Branch: feature/ec

commit 716ad3e07b06c84271e6059dbafaf3b6e735cfc7
Author: Chmouel Boudjnah <email address hidden>
Date: Fri Aug 9 17:16:36 2013 +0200

Add libcloud to associated_projects.

Change-Id: I8778bbecc7ae5852cf789ae6b71191004f69861f

commit e8a593fbf014f3a1ba94f1cbeb64037abacc84e5
Author: John Dickinson <email address hidden>
Date: Fri Aug 9 07:50:28 2013 -0700

added a couple of java libraries to associated projects

Change-Id: I7a554af509e8d9743a8416a051845c266e1fb9f6

commit 5a785aa5ee038798b59193fd820e7100ebf119c5
Author: Monty Taylor <email address hidden>
Date: Sun Aug 4 16:10:49 2013 -0400

Add missing copyright license headers

    We're working on adding enforcement that things have appropriate
    copyright license headers. In anticipation of that, fix the files that don't
    have them.

Change-Id: Ie0a9fd5eece5b6671ff4389b07b69ca29be7d017

commit 1fc2742314a7ebfef52598538ec34fab36ae8866
Author: John Dickinson <email address hidden>
Date: Wed Aug 7 08:40:54 2013 -0700

version bump to reflect current dev target

Change-Id: I5db26319ba642c6447527f50c7316b8b5933871d

commit bc998f8c36ed951cd03d685b474613e67b49fed3
Author: John Dickinson <email address hidden>
Date: Tue Aug 6 11:20:32 2013 -0700

CHANGELOG and AUTHORS and .mailmap updates for 1.9.1

Change-Id: I34b28ffd7971a99b727c5149bdddeb9c6020e1df

commit 6b9806e0e8cbec60c0a3ece0bd516e0502827515
Author: Peter Portante <email address hidden>
Date: Tue Jul 2 11:48:19 2013 -0400

Fix handling of DELETE obj reqs with old timestamp

    The DELETE object REST API was creating tombstone files with old
    timestamps, potentially filling up the disk, as well as sending
    container updates.

    Here we now make DELETEs with a request timestamp return a 409 (HTTP
    Conflict) if a data file exists with a newer timestamp, only creating
    tombstones if they have a newer timestamp.

    The key fix is to actually read the timestamp metadata from an
    existing tombstone file (thanks to Pete Zaitcev for catching this),
    and then only create tombstone files with newer timestamps.

We also prevent PUT and POST operations using old timestamps as well.

Change-Id: I631957029d17c6578bca5779367df5144ba01fc9
Signed-off-by: Peter Portante <email address hidden>

commit 69f9f9e88aade6634b7b72bb22dc2c48fbc87460
Author: Wu Wenxiang <wu.wenxiang@99cloud.net>
Date: Sun Aug 4 11:15:53 2013 +0800

Assignment to reserved built-in symbol

    Built-in symbol: file, format, range etc was re-assigned as local vars
    in files: test/functional/swift_test_client.py and
    test/functional/tests.py, rename these local vars.

Fixes bug #1208078

Change-Id: I627894cd722bd32cad231d534cbe97a0412c7cc9

commit 64756f8d17adf55d8c2cdf2413023a451ea9d566
Author: Chmouel Boudjnah <email address hidden>
Date: Tue Aug 6 12:58:59 2013 +0200

Use /var/run/syslog on macosx for syslog tests.

- This patch is based on zaictev ...

Reviewed:  https://review.openstack.org/41478
Committed: http://github.com/openstack/swift/commit/6fff883838b823335f4f4104113112a47e4a5a30
Submitter: Jenkins
Branch:    feature/ec

commit 716ad3e07b06c84271e6059dbafaf3b6e735cfc7
Author: Chmouel Boudjnah <chmouel@enovance.com>
Date:   Fri Aug 9 17:16:36 2013 +0200

Add libcloud to associated_projects.
    
    Change-Id: I8778bbecc7ae5852cf789ae6b71191004f69861f

commit e8a593fbf014f3a1ba94f1cbeb64037abacc84e5
Author: John Dickinson <me@not.mn>
Date:   Fri Aug 9 07:50:28 2013 -0700

added a couple of java libraries to associated projects
    
    Change-Id: I7a554af509e8d9743a8416a051845c266e1fb9f6

commit 5a785aa5ee038798b59193fd820e7100ebf119c5
Author: Monty Taylor <mordred@inaugust.com>
Date:   Sun Aug 4 16:10:49 2013 -0400

Add missing copyright license headers
    
    We're working on adding enforcement that things have appropriate
    copyright license headers. In anticipation of that, fix the files that don't
    have them.
    
    Change-Id: Ie0a9fd5eece5b6671ff4389b07b69ca29be7d017

commit 1fc2742314a7ebfef52598538ec34fab36ae8866
Author: John Dickinson <me@not.mn>
Date:   Wed Aug 7 08:40:54 2013 -0700

version bump to reflect current dev target
    
    Change-Id: I5db26319ba642c6447527f50c7316b8b5933871d

commit bc998f8c36ed951cd03d685b474613e67b49fed3
Author: John Dickinson <me@not.mn>
Date:   Tue Aug 6 11:20:32 2013 -0700

CHANGELOG and AUTHORS and .mailmap updates for 1.9.1
    
    Change-Id: I34b28ffd7971a99b727c5149bdddeb9c6020e1df

commit 6b9806e0e8cbec60c0a3ece0bd516e0502827515
Author: Peter Portante <peter.portante@redhat.com>
Date:   Tue Jul 2 11:48:19 2013 -0400

Fix handling of DELETE obj reqs with old timestamp
    
    The DELETE object REST API was creating tombstone files with old
    timestamps, potentially filling up the disk, as well as sending
    container updates.
    
    Here we now make DELETEs with a request timestamp return a 409 (HTTP
    Conflict) if a data file exists with a newer timestamp, only creating
    tombstones if they have a newer timestamp.
    
    The key fix is to actually read the timestamp metadata from an
    existing tombstone file (thanks to Pete Zaitcev for catching this),
    and then only create tombstone files with newer timestamps.
    
    We also prevent PUT and POST operations using old timestamps as well.
    
    Change-Id: I631957029d17c6578bca5779367df5144ba01fc9
    Signed-off-by: Peter Portante <peter.portante@redhat.com>

commit 69f9f9e88aade6634b7b72bb22dc2c48fbc87460
Author: Wu Wenxiang <wu.wenxiang@99cloud.net>
Date:   Sun Aug 4 11:15:53 2013 +0800

Assignment to reserved built-in symbol
    
    Built-in symbol: file, format, range etc was re-assigned as local vars
    in files: test/functional/swift_test_client.py and
    test/functional/tests.py, rename these local vars.
    
    Fixes bug #1208078
    
    Change-Id: I627894cd722bd32cad231d534cbe97a0412c7cc9

commit 64756f8d17adf55d8c2cdf2413023a451ea9d566
Author: Chmouel Boudjnah <chmouel@enovance.com>
Date:   Tue Aug 6 12:58:59 2013 +0200

Use /var/run/syslog on macosx for syslog tests.
    
    - This patch is based on zaictev review.
    - Fixes bug 1206560.
    
    Change-Id: I41f3d485df41fe443784f803b276712405fe72c6

commit 0e96911aada553b4e1a00131732894ce533af403
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date:   Mon Aug 5 20:38:01 2013 -0600

Increase test coverage of swift/common/db.py
    
    The most low hanging fruit is _preallocate(). As it turns out,
    we never excercise the calculations because we never give it
    a file that exists.
    
    This version uses mock.patch everywhere.
    
    Change-Id: I5df03aff295d2a1bca252a02b3985a6bc3eecb26

commit 358a03325b549f30cefa0c67e264d3d8a1b63059
Author: Alex Gaynor <alex.gaynor@gmail.com>
Date:   Mon Aug 5 15:35:34 2013 -0700

Ensure http_connect is mocked out in tests
    
    Otherwise this test will try to connect to several addresses that aren't
    mapped. On Linux the entier 127.0.0.* block is mapped to localhost, so this
    often isn't noticed, but on OS X only 127.0.0.1 is mapped by default.
    
    Change-Id: I44034d5006ff25e052afdb6599ab5838e4c5ae5b

commit 7f1aa9d1e838f48b91966fa44e179c82b2b116b7
Author: Vincent Untz <vuntz@suse.com>
Date:   Fri Jul 12 08:11:27 2013 +0200

Allow dispersion tools to use keystone server with insecure certificate
    
    The swift-dispersion-populate and swift-dispersion-report tools now
    accept a --insecure option.
    
    Also, dispersion.conf now has a keystone_api_insecure option.
    
    Default is obviously to use the secure path.
    
    DocImpact
    
    Change-Id: I4000352e547d9ce5b08ade54e0c886281caff891

commit 5f43e257e9e4c8db26033bb003dce710ad40c5c6
Author: Sascha Peilicke <saschpe@gmx.de>
Date:   Mon Aug 5 15:36:48 2013 +0200

Clarify staticweb configuration with keystone.
    
    Since staticweb works with anonymous requests by default, explictly
    mention delay_auth_decision for the authtoken middleware in
    /etc/swift/proxy-server.conf.
    
    Change-Id: I4879884b22224843cf9d4a50ba3359fac36957dc

commit 2690a4e60476975a74b73006c76373e10438ddf5
Author: Chmouel Boudjnah <chmouel@enovance.com>
Date:   Mon Aug 5 09:28:47 2013 +0000

Fix sphinx error in swift.common.utils
    
    - Error was swift/common/utils.py:docstring of
      swift.common.utils.parse_content_type:7: ERROR: Unexpected
      indentation.
    - Closes-Bug: #1208396
    
    Change-Id: Ia0c095d1b0b202e99991aabdf96e12b52c922c5c

commit 657a0e4e26492af305e63aee9958190daa811605
Author: Koert van der Veer <koert@cloudvps.com>
Date:   Mon Aug 5 09:55:54 2013 +0200

Add swift-basicauth and better-staticweb to associated projects.
    
    As announced here:
    http://openstack.markmail.org/thread/jjjbdpurhb5jwaxe
    
    Change-Id: I683c463745b34c003ecb79ba8261b94b9dc166b6

commit 6895bb6589c883560e16c4495130a5866514d7ce
Author: Wu Wenxiang <wu.wenxiang@99cloud.net>
Date:   Fri Aug 2 21:04:24 2013 +0800

Correct misspell in comments
    
    In file: test/functional/tests.py
    
    Change-Id: I4440123b95e38b40a7a0a5f1f031941f42c1085e

commit d819354c766fe3bc76d1bdbecde2e18515a1fd70
Author: gholt <z-launchpad@brim.net>
Date:   Thu Aug 1 13:09:13 2013 +0000

Just a tiny doc fix for a Sphinx warning
    
    Change-Id: Iede31212065eafb94fd29a63103e1e73e2de770d

commit f242311b209d9aa634622545b1818ac81521ed72
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date:   Wed Jul 31 16:01:15 2013 -0600

Make pending_timeout an argument of __init__
    
    Just like stale_reads_ok, this was already an argument, end even
    used by the replicator that way. We only make it used exclusively
    this way, so that we can document it for LFS.
    
    Change-Id: Ib722093a476ec75d87917b37b40b77dcf2627330

commit 6c3619469264d7dff05838fb632c546289df4e6e
Author: Kun Huang <academicgareth@gmail.com>
Date:   Wed Jul 31 11:50:06 2013 +0800

give value [] if disallowed_metadata_keys is None
    
    The default value of DiskFile.disallowed_metadata_keys is None. And it
    will be iter in following codes even if it didn't get a new value. So
    it is necessary to give Diskfile.disallowed_metadata_keys an empty list
    in __init__ if the default value None is used.
    
    fixes bug #1206740
    
    Change-Id: I8454eba47b2c691166924356ab33b0235a800951

commit e448b2f5f7094ed64a203785221c88edd1dd88b8
Author: Chmouel Boudjnah <chmouel@enovance.com>
Date:   Tue Jul 30 17:16:59 2013 +0200

Fake http_connect in test_replicator test
    
    - mock http_connect in replicator.test_delete_partition test to not
      connect directly on 127.0.0.1 (which is not always avail on non
      linuxies).
    - Fixes bug 1203907
    
    Change-Id: I2622223c9fe5a3db2a113b6cd8d028a5db0915a7

commit 53345da70e3c969168e7192c3098540ba642ea09
Author: Michael Barton <mike@weirdlooking.com>
Date:   Tue Jul 23 14:54:51 2013 -0700

some container serialization cleanup
    
    Have json and xml use common record cleanup code.
    Do a somewhat better job of parsing extensions from content-types.
    Use a real XML serializer.
    
    Change-Id: I10e14dffd1da590b4fd180b4d33ab5de862e2b55

commit adbe86990e5d68612169f22fbe5de4f0eded8912
Author: Chmouel Boudjnah <chmouel@enovance.com>
Date:   Thu Jul 11 17:19:25 2013 +0200

Remove duplicated code in direct_client.
    
    - Add a base function _get_direct_account_container to do the direct
      account stuff instead of duplicating both methods.
    
    Change-Id: I12059a741dd22d0dde20012d1dbc4be9b8e90957

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.