Ubuntu
indicator-session package

Auth issue for Online Accounts highlights session menu title

Bug #1206550 reported by Sebastien Bacher
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Session Menu
Fix Released
Undecided
Unassigned
libindicator
Invalid
Undecided
Unassigned
indicator-session (Ubuntu)
Fix Released
Undecided
Charles Kerr

Bug Description

Currently, in saucy, the icon turns red but the menu gives no indication of why, I think it used to display a red label in the menu as well

Related branches

lp://staging/~charlesk/indicator-session/lp-1206550
PS Jenkins bot (community): Approve (continuous-integration)
Indicator Applet Developers: Pending requested
Diff: 200 lines (+35/-66)
3 files modified
src/service.c (+2/-37)
tests/gtest-dbus-fixture.h (+32/-23)
tests/test-service.cc (+1/-6)
lp://staging/ubuntu/trusty-proposed/indicator-session
Charles Kerr (charlesk)
Changed in indicator-session:
assignee: nobody → Charles Kerr (charlesk)
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in indicator-session (Ubuntu):
status: New → Confirmed
Revision history for this message
Charles Kerr (charlesk) wrote :

This was possible in the older version of indicator-session because it controlled the GtkMenu. If we make the menuitem's text red now, it'll take code in multiple packages. From a code point of view, maybe an error icon would be simpler? :)

More importantly, I don't see any discussion of this in the SystemMenu spec. Let's get Matthew's opinion first.

Changed in indicator-session:
assignee: Charles Kerr (charlesk) → Matthew Paul Thomas (mpt)
status: Triaged → New
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

The title color change is obsolete: it dates from the time when we had separate user and device menus, where the user menu had a specific "Online Accounts..." item that could turn red. <https://wiki.ubuntu.com/DeviceMenuAndUserMenu#User_menu> Nowadays we have a combined session menu containing only a "System Settings..." item.

There are many possible error states inside System Settings panels: your default printer may be offline, your default software update server may be unreachable, there may be no keyboard connected, your backup storage location may no longer be mounted, and so on. Each of those should be flagged with a helpful error message at the point of need, not by special-casing the title and contents of the session menu. For example, a prompt for you to reauthorize an online account could appear if and when an app actually tries to use that account. Please remove the red title.

Matthew Paul Thomas (mpt)
Changed in indicator-session:
assignee: Matthew Paul Thomas (mpt) → nobody
summary: - when online accounts have auth issue, the indicator should display a red
- color line
+ Auth issue for Online Accounts highlights session menu title with
+ nothing inside
summary: - Auth issue for Online Accounts highlights session menu title with
- nothing inside
+ Auth issue for Online Accounts highlights session menu title
Charles Kerr (charlesk)
Changed in indicator-session (Ubuntu):
assignee: nobody → Charles Kerr (charlesk)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-session - 12.10.5+14.04.20140324-0ubuntu1

---------------
indicator-session (12.10.5+14.04.20140324-0ubuntu1) trusty; urgency=low

  [ Charles Kerr ]
  * Don't show a red icon in indicator-session when there's an online
    user account error. (LP: #1206550)

  [ Iain Lane ]
  * Re-add the feature to hide the user list if
    com.canonical.indicator.session user-show-menu is false (LP:
    #1211772)
 -- Ubuntu daily release <email address hidden> Mon, 24 Mar 2014 10:19:12 +0000

Changed in indicator-session (Ubuntu):
status: Confirmed → Fix Released
Charles Kerr (charlesk)
Changed in indicator-session:
status: New → Fix Released
Changed in libindicator:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.