Glance

glance-replicator will expose trace when no args given

Bug #1202513 reported by Feilong Wang on 2013-07-18

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Glance	Fix Released	Undecided	Feilong Wang	Glance 2013.2 "havana"

Bug Description

Based on current implement, glance-replicator will expose trace if there is no fromserver:port and toserver:port given. The trace is as below.

flwang@flwang-ThinkPad-X230:~/MyWorkSpace/workspace_community/glance$ glance-replicator livecopy
Traceback (most recent call last):
  File "/usr/local/bin/glance-replicator", line 9, in <module>
    load_entry_point('glance==2013.2.a116.gd13493b', 'console_scripts', 'glance-replicator')()
  File "/usr/local/lib/python2.7/dist-packages/glance-2013.2.a116.gd13493b-py2.7.egg/glance/cmd/replicator.py", line 733, in main
    command(options, args)
  File "/usr/local/lib/python2.7/dist-packages/glance-2013.2.a116.gd13493b-py2.7.egg/glance/cmd/replicator.py", line 448, in replication_livecopy
    slave_server_port = args.pop()
IndexError: pop from empty list

Feilong Wang (flwang) on 2013-07-18

Changed in glance:
assignee:	nobody → Fei Long Wang (flwang)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-07-19: Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/37844

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-07-29: Fix merged to glance (master)

Reviewed: https://review.openstack.org/37844
Committed: http://github.com/openstack/glance/commit/8a6271eee52e354332a89027d03e6a1e192abb9c
Submitter: Jenkins
Branch: master

commit 8a6271eee52e354332a89027d03e6a1e192abb9c
Author: Fei Long Wang <email address hidden>
Date: Fri Jul 19 15:24:04 2013 +0800

Adding arguments pre-check for glance-replicator

    Based on current implement, glance-replicator will expose trace
    if there is no arguments specified or the server:port format is bad.
    This fix will add pre-check for those sub commands.

Fix bug 1202513

Change-Id: Ib8a90ce583cf938c9fdc0e8ad36af2ef8dfc976b