Mir

Should expose the session that a new surface is for

Bug #1200035 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Michael Terry
Mir 0.0.9
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I want to override the_surface_builder() in u-s-c to change the DepthId of a new surface based on the session name. But I can't seem to get access to the session that a surface is being created for.

It seems like information that should be available to surface builders. Please make it so?

Related branches

lp://staging/~mterry/mir/session-for-surface
Alan Griffiths: Abstain
PS Jenkins bot (community): Approve (continuous-integration)
Kevin DuBois (community): Abstain
Robert Carr (community): Approve
Robert Ancell: Approve
Diff: 691 lines (+87/-42)
23 files modified
examples/render_surfaces.cpp (+1/-0)
include/server/mir/shell/organising_surface_factory.h (+2/-0)
include/server/mir/shell/surface.h (+2/-0)
include/server/mir/shell/surface_builder.h (+2/-1)
include/server/mir/shell/surface_factory.h (+2/-0)
include/server/mir/shell/surface_source.h (+2/-0)
include/server/mir/surfaces/surface_controller.h (+6/-1)
include/test/mir_test_doubles/mock_surface.h (+2/-2)
include/test/mir_test_doubles/mock_surface_factory.h (+2/-1)
include/test/mir_test_doubles/stub_surface_builder.h (+1/-1)
src/server/shell/application_session.cpp (+1/-1)
src/server/shell/organising_surface_factory.cpp (+2/-1)
src/server/shell/surface.cpp (+2/-1)
src/server/shell/surface_source.cpp (+2/-1)
src/server/surfaces/surface_controller.cpp (+2/-1)
tests/acceptance-tests/test_client_input.cpp (+3/-2)
tests/integration-tests/graphics/android/test_internal_client.cpp (+1/-1)
tests/unit-tests/shell/test_application_session.cpp (+10/-10)
tests/unit-tests/shell/test_default_focus_mechanism.cpp (+2/-2)
tests/unit-tests/shell/test_organising_surface_factory.cpp (+5/-5)
tests/unit-tests/shell/test_session_manager.cpp (+6/-4)
tests/unit-tests/shell/test_surface.cpp (+28/-6)
tests/unit-tests/surfaces/test_surface_controller.cpp (+1/-1)
lp://staging/ubuntu/saucy-proposed/mir
Michael Terry (mterry)
Changed in mir:
assignee: nobody → Michael Terry (mterry)
Revision history for this message
Kevin DuBois (kdub) wrote :

moved to wishlist... seems to be more of a feature request than a problem with the code.

Changed in mir:
importance: Undecided → Wishlist
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I'm going to assign this as a medium priority bug - this is driven by u-s-c being unable to consume the API to implement the required functionality. The solution either needs to involve changes to the API, or advice given on the correct way to use it.

Changed in mir:
importance: Wishlist → Medium
status: New → Triaged
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.9

Changed in mir:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.0.8+13.10.20130809.4-0ubuntu1

---------------
mir (0.0.8+13.10.20130809.4-0ubuntu1) saucy; urgency=low

  [ Michael Terry ]
  * Pass on the owning Session when creating Surfaces. (LP: #1200035)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 952
 -- Ubuntu daily release <email address hidden> Fri, 09 Aug 2013 18:05:05 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
Robert Ancell (robert-ancell)
Changed in mir:
milestone: none → 0.0.9
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.