nested stack error path test coverage lacking

Bug #1195310 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Liang Chen

Bug Description

Ref:

https://review.openstack.org/#/c/34530/1/heat/engine/stack_resource.py

I tried to write a test to cover that one line of error-path in nested stack creation - it's actually quite hard due to the nestedness and coroutine magic, so like a true engineer I gave up and moved on to something easier ;)

Raising this to track figuring out the cleanest way to add coverage and avoid errors like the one captured in the patch above.

Revision history for this message
Thomas Herve (therve) wrote :

Relatedly, it should be easy to adapt the create test for the suspend case.

Steven Hardy (shardy)
Changed in heat:
milestone: none → havana-3
status: New → Triaged
importance: Undecided → Low
Liang Chen (cbjchen)
Changed in heat:
assignee: nobody → Liang Chen (cbjchen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/35999

Changed in heat:
status: Triaged → In Progress
Changed in heat:
milestone: havana-3 → havana-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/35999
Committed: http://github.com/openstack/heat/commit/7c74d880a68eca8a29eaf397cf873b8c2201b1b6
Submitter: Jenkins
Branch: master

commit 7c74d880a68eca8a29eaf397cf873b8c2201b1b6
Author: Liang Chen <email address hidden>
Date: Fri Jul 5 00:45:01 2013 +0800

    provide test for nested stack error path

    Fixes bug #1195310

    Change-Id: I3c77287c92068b305f61fa4cbe4846aa56ab50e0

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.