OpenStack Identity (keystone)

Remove context parameter from manager

Bug #1194938 reported by Adam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Adam Young
OpenStack Identity (keystone) 2013.2 "havana"

Bug Description

keystone/common/manager.py strips the context object out of the calls to the manage. This parameter is unused. The only justification for it is to do logging, which will instead be done via a combination of policy and the currentl logging infrastructure, which means it does not need a context object on which to operate. The EMPTY_CONTEXT code is all over the place, and should be removed.

Dolph Mathews (dolph)
Changed in keystone:
importance: Low → Wishlist
Dolph Mathews (dolph)
Changed in keystone:
assignee: Adam Young (ayoung) → Dolph Mathews (dolph)
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34752

Changed in keystone:
status: Triaged → In Progress
OpenStack Infra (hudson-openstack)
Changed in keystone:
assignee: Dolph Mathews (dolph) → Adam Young (ayoung)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/34752
Committed: http://github.com/openstack/keystone/commit/911c3156563c4e33bff3b4652b30c744f8b12de6
Submitter: Jenkins
Branch: master

commit 911c3156563c4e33bff3b4652b30c744f8b12de6
Author: Dolph Mathews <email address hidden>
Date: Thu Jun 27 10:35:39 2013 -0500

    Stop passing context to managers (bug 1194938)

    We don't have a use case for passing the request context to the manager
    layer, so this patch removes a bunch of cruft.

    Change-Id: Ic6435782c4c9f32e38c7800172645cc1af23ea09

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.