Ironic

'extra' should be dict_or_none, not str_or_none

Bug #1194072 reported by Roman Prykhodchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Roman Prykhodchenko
Ironic 2014.1 "icehouse"

Bug Description

Current implementation defines 'extra' fields for Chassis and Port as str_or_none. This should be changed to dict_or_none.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34179

Changed in ironic:
assignee: nobody → Roman Prykhodchenko (prykhodchenko)
status: New → In Progress
aeva black (tenbrae)
Changed in ironic:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/34179
Committed: http://github.com/openstack/ironic/commit/1541b40456eade6cd976ab8491e98c943db8bd95
Submitter: Jenkins
Branch: master

commit 1541b40456eade6cd976ab8491e98c943db8bd95
Author: Roman Prykhodchenko <email address hidden>
Date: Mon Jun 24 12:57:18 2013 +0300

    Re-define 'extra' as dict_or_none.

    Changed type of 'extra' fields from str_or_none
    to dict_or_none for Port and Chassis.

    DB model defines 'extra' as a JSONEncodedDict which is
    a type decorator that stores a value as a json string
    to the database and parses it to a dict when loading the
    object. That's why we need to change the type of the
    'extra' field from str_or_none to dict_or_none.

    Test utils have been modified to simulate behavior of
    DB layer better.

    Fixes: bug #1194072

    Change-Id: I2c73069f795754078ce8cba50ee669cce2f4b27d

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.