neutron

policy engine swallows exception on critical code execution

Bug #1191948 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Armando Migliaccio
neutron 2013.2 "havana"

Bug Description

I have noticed that if the following code (where F is a plugin method):

            data = f(context.get_admin_context(),
                     target[parent_foreign_key],
                     fields=[parent_field])
            target[self.target_field] = data[parent_field]

raises an exception this is not logged making very hard to understand why the policy check has failed.

Tags: api
Armando Migliaccio (armando-migliaccio)
Changed in quantum:
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/33339

Changed in quantum:
status: New → In Progress
Mark McClain (markmcclain)
tags: added: api
Changed in quantum:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/33339
Committed: http://github.com/openstack/quantum/commit/8eea1ae574671a157ae2d215f18635a3c8985a06
Submitter: Jenkins
Branch: master

commit 8eea1ae574671a157ae2d215f18635a3c8985a06
Author: armando-migliaccio <email address hidden>
Date: Mon Jun 17 13:33:46 2013 -0700

    Make sure exceptions during policy checks are logged.

    If the invocation of f bombs out, the policy check fails (i.e. returns
    False), however it does not log the root cause, which makes very
    difficult to understand why this is happening.

    Fixes bug #1191948

    Change-Id: Ic40053f3965b71199baf9fe3902e8ffc9745076f

Changed in quantum:
status: In Progress → Fix Committed
Mark McClain (markmcclain)
Changed in quantum:
milestone: none → havana-2
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.