PBR

Comments in requirements.txt are not parsed

Bug #1191923 reported by Amir Sadoughi on 2013-06-17

This bug affects 6 people

	Status	Importance	Assigned to	Milestone
Designate	Fix Released	Undecided	Kiall Mac Innes
OpenStack Heat	Fix Released	Undecided	Steven Hardy	OpenStack Heat 2013.2 "havana"
PBR	Fix Released	Undecided	Monty Taylor
neutron	Fix Released	Medium	Hirofumi Ichihara	neutron 2013.2 "havana"

Bug Description

I've ran python setup.py install in the latest quantum and pbr choked on parsing a line leading with a #:

(venv)amir@devbox:~/bug/quantum$ python setup.py install
running install
Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    d2to1=True)
  File "/usr/lib/python2.7/distutils/core.py", line 152, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/home/amir/bug/quantum/pbr-0.5.17-py2.7.egg/pbr/packaging.py", line 310, in run
    _pip_install(links, self.distribution.install_requires, self.root)
  File "/home/amir/bug/quantum/pbr-0.5.17-py2.7.egg/pbr/packaging.py", line 95, in _pip_install
    " ".join(_wrap_in_quotes(_missing_requires(requires)))),
  File "/home/amir/bug/quantum/pbr-0.5.17-py2.7.egg/pbr/packaging.py", line 83, in _missing_requires
    pkg_resources.Requirement.parse(r))]
  File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2598, in parse
    raise ValueError("No requirements found", s)
ValueError: ('No requirements found', '# Cisco plugin dependencies')

Amir Sadoughi (amir-sadoughi) on 2013-06-17

summary:

- Comments are not parsed
+ Comments in requirements.txt are not parsed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-06-28: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/34892

Changed in heat:
assignee:	nobody → Steven Hardy (shardy)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-06-28: Fix merged to heat (master)

Reviewed: https://review.openstack.org/34892
Committed: http://github.com/openstack/heat/commit/da3b5ecfdd0c64805b40ecb535c077f9f0044988
Submitter: Jenkins
Branch: master

commit da3b5ecfdd0c64805b40ecb535c077f9f0044988
Author: Steven Hardy <email address hidden>
Date: Fri Jun 28 15:50:01 2013 +0100

Remove comments from requirements.txt (workaround pbr bug)

Workaround for pbr bug #1191923

Change-Id: I4960216834cf624d8bcf88e7a3e7485cf5ace85f

Changed in heat:
status:	In Progress → Fix Committed

Mark McClain (markmcclain) on 2013-07-07

Changed in neutron:
importance:	Undecided → Medium
status:	New → Triaged

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-07-09: Fix merged to designate (master)

Reviewed: https://review.openstack.org/36208
Committed: http://github.com/stackforge/designate/commit/5e7219aa7ccfecaf061ce961dabb5c6b4413c1a0
Submitter: Jenkins
Branch: master

commit 5e7219aa7ccfecaf061ce961dabb5c6b4413c1a0
Author: Kiall Mac Innes <email address hidden>
Date: Tue Jul 9 12:31:44 2013 +0100

Remove comments from *requirements.txt (workaround pbr bug)

Workaround for pbr bug #1191923

Change-Id: Iebf4bd311006be9fe1b4fcc5753886aaa5805461

Changed in designate:
status:	New → Fix Committed

Kiall Mac Innes (kiall) on 2013-07-11

Changed in designate:
status:	Fix Committed → Fix Released
assignee:	nobody → Kiall Mac Innes (kiall)

Thierry Carrez (ttx) on 2013-07-17

Changed in heat:
milestone:	none → havana-2
status:	Fix Committed → Fix Released

Hirofumi Ichihara (ichihara-hirofumi) on 2013-07-31

Changed in neutron:
assignee:	nobody → Hirofumi Ichihara (ichihara-hirofumi)
status:	Triaged → In Progress

Hirofumi Ichihara (ichihara-hirofumi) on 2013-08-05

Changed in neutron:
status:	In Progress → Fix Committed

Mark McClain (markmcclain) on 2013-08-05

Changed in neutron:
milestone:	none → havana-3

Monty Taylor (mordred) on 2013-08-11

Changed in pbr:
status:	New → Fix Released
assignee:	nobody → Monty Taylor (mordred)

Thierry Carrez (ttx) on 2013-09-05

Changed in neutron:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-10-17

Changed in heat:
milestone:	havana-2 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in neutron:
milestone:	havana-3 → 2013.2

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1191801

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.