OpenStack Heat

Loadbalancer update doesn't work

Bug #1191705 reported by Steven Hardy on 2013-06-17

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Heat	Fix Released	High	Steven Hardy	OpenStack Heat 2013.2 "havana"

Bug Description

Since https://review.openstack.org/#/c/31083/ Loadbalancer update doesn't work - looks like the error is in resource.py where we need to resolve the template snippet before passing it to handle_update for the resource.

2013-06-17 09:24:50.177 1330 ERROR heat.engine.resource [-] CREATE : AutoScalingGroup "WebServerGroup"
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource Traceback (most recent call last):
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resource.py", line 335, in _do_action
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource while not check(handle_data):
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resources/autoscaling.py", line 84, in check_create_complete
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource return creator.step()
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/scheduler.py", line 160, in step
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource next(self._runner)
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/scheduler.py", line 253, in wrapper
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource subtask = next(parent)
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resources/autoscaling.py", line 145, in _scale
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource self._lb_reload()
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resources/autoscaling.py", line 213, in _lb_reload
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource self.stack[lb].update(self.stack[lb].json_snippet)
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resource.py", line 424, in update
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource raise failure
2013-06-17 09:24:50.177 1330 TRACE heat.engine.resource ResourceFailure: TypeError: "{u'Fn::GetAZs': u''}" is not a list

Steven Hardy (shardy) on 2013-06-17

Changed in heat:
status:	New → Triaged
importance:	Undecided → High
assignee:	nobody → Steven Hardy (shardy)
milestone:	none → havana-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-06-18: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/33431

Changed in heat:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-06-18: Fix merged to heat (master)

Reviewed: https://review.openstack.org/33431
Committed: http://github.com/openstack/heat/commit/a780bef9c396ffa6cd0a6e433bac5447a320c9fb
Submitter: Jenkins
Branch: master

commit a780bef9c396ffa6cd0a6e433bac5447a320c9fb
Author: Steven Hardy <email address hidden>
Date: Mon Jun 17 15:54:51 2013 +0100

autoscaling fix LoadBalancer reload static resolve

    Since https://review.openstack.org/#/c/31083/ we're using the
    Resource.update() method to update the LoadBalancer, which requires
    the resource snippet to be statically resolved (as is done in
    parser.Stack for stack updates)

Fixes bug #1191705

Change-Id: Id2017a912472ddb48245682c5b6392cbcb9e4c60