Add iconName property to Action and ActionItem in addition to iconSource
Bug #1191054 reported by
Tim Peeters
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
High
|
Florian Boucault | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Icons can also be specified by name.
Related branches
lp://staging/~fboucault/ubuntu-ui-toolkit/icon_api_sanitization
- Tim Peeters: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 932 lines (+379/-42)28 files modifiedCHANGES (+13/-0)
components.api (+14/-0)
examples/ubuntu-ui-toolkit-gallery/ListItems.qml (+2/-2)
examples/ubuntu-ui-toolkit-gallery/OptionSelectors.qml (+1/-1)
modules/Ubuntu/Components/AbstractButton.qml (+1/-1)
modules/Ubuntu/Components/Action.qml (+28/-1)
modules/Ubuntu/Components/ActionItem.qml (+12/-2)
modules/Ubuntu/Components/Button.qml (+3/-3)
modules/Ubuntu/Components/Icon.qml (+8/-0)
modules/Ubuntu/Components/ListItems/Base.qml (+54/-3)
modules/Ubuntu/Components/ListItems/IconVisual.qml (+6/-0)
modules/Ubuntu/Components/ListItems/ItemSelector.qml (+1/-1)
modules/Ubuntu/Components/ListItems/MultiValue.qml (+1/-1)
modules/Ubuntu/Components/ListItems/SingleValue.qml (+1/-1)
modules/Ubuntu/Components/ListItems/Standard.qml (+55/-4)
modules/Ubuntu/Components/ListItems/Subtitled.qml (+2/-2)
modules/Ubuntu/Components/ListItems/ValueSelector.qml (+49/-2)
modules/Ubuntu/Components/OptionSelector.qml (+1/-1)
modules/Ubuntu/Components/OptionSelectorDelegate.qml (+36/-3)
modules/Ubuntu/Components/Tabs.qml (+1/-2)
modules/Ubuntu/Components/TextField.qml (+2/-2)
modules/Ubuntu/Components/ToolbarButton.qml (+3/-3)
modules/Ubuntu/Components/ToolbarItems.qml (+2/-2)
tests/resources/navigation/Tabs.qml (+1/-1)
tests/unit/tst_components/tst_action.qml (+67/-0)
tests/unit/tst_components/tst_actionitem.qml (+11/-0)
tests/unit_x11/tst_components/tst_listitems_itemselector.qml (+2/-2)
tests/unit_x11/tst_components/tst_optionselector.qml (+2/-2)
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Florian Boucault (fboucault) |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-ui-toolkit at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown