OpenStack Heat

tox outputs AttributeError:'NoneType' object has no attribute 'update_and_save'

Bug #1182285 reported by Winson Chan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Thomas Herve
OpenStack Heat 2013.2 "havana"

Bug Description

When running tox, console output contains the following error but reported success.

Traceback (most recent call last):
  File "/opt/stack/heat/.tox/py26/lib/python2.6/site-packages/eventlet/hubs/hub.py", line 346, in fire_timers
    timer()
  File "/opt/stack/heat/.tox/py26/lib/python2.6/site-packages/eventlet/hubs/timer.py", line 56, in __call__
    cb(*args, **kw)
  File "/opt/stack/heat/.tox/py26/lib/python2.6/site-packages/eventlet/greenthread.py", line 194, in main
    result = function(*args, **kwargs)
  File "/opt/stack/heat/heat/engine/parser.py", line 498, in delete
    self.state_set(self.DELETE_IN_PROGRESS, 'Stack deletion started')
  File "/opt/stack/heat/heat/engine/parser.py", line 264, in state_set
    stack.update_and_save({'status': new_status,
AttributeError: 'NoneType' object has no attribute 'update_and_save'
Traceback (most recent call last):
  File "/opt/stack/heat/.tox/py26/lib/python2.6/site-packages/eventlet/hubs/hub.py", line 346, in fire_timers
    timer()
  File "/opt/stack/heat/.tox/py26/lib/python2.6/site-packages/eventlet/hubs/timer.py", line 56, in __call__
    cb(*args, **kw)
  File "/opt/stack/heat/.tox/py26/lib/python2.6/site-packages/eventlet/greenthread.py", line 194, in main
    result = function(*args, **kwargs)
  File "/opt/stack/heat/heat/engine/parser.py", line 332, in update
    'State invalid for update')
  File "/opt/stack/heat/heat/engine/parser.py", line 264, in state_set
    stack.update_and_save({'status': new_status,
AttributeError: 'NoneType' object has no attribute 'update_and_save'

Steve Baker (steve-stevebaker)
Changed in heat:
assignee: nobody → Zane Bitter (zaneb)
Steven Hardy (shardy)
Changed in heat:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → havana-1
Zane Bitter (zaneb)
Changed in heat:
assignee: Zane Bitter (zaneb) → Thomas Herve (therve)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/30060

Changed in heat:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/30076

Changed in heat:
assignee: Thomas Herve (therve) → Zane Bitter (zaneb)
Zane Bitter (zaneb)
Changed in heat:
assignee: Zane Bitter (zaneb) → Thomas Herve (therve)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/30060
Committed: http://github.com/openstack/heat/commit/14354874dec15ce148489cdd85420c6334a6e5fc
Submitter: Jenkins
Branch: master

commit 14354874dec15ce148489cdd85420c6334a6e5fc
Author: Thomas Herve <email address hidden>
Date: Wed May 22 10:23:50 2013 +0200

    Remove unrelated tracebacks from test output

    This mocks some calls the ThreadGroup when testing update and delete of
    the stack, resulting in tracebacks when the threads randomly run later
    on in the test suite.

    Change-Id: Ia1a376933c2e25b6cf0fe6a26f47e381cbb1a55e
    Fixes: bug #1182285

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/30076
Committed: http://github.com/openstack/heat/commit/fb59cbd709058f8ed0ad9eabb891c79d31d0b044
Submitter: Jenkins
Branch: master

commit fb59cbd709058f8ed0ad9eabb891c79d31d0b044
Author: Zane Bitter <email address hidden>
Date: Wed May 22 12:40:33 2013 +0200

    Stub out sleeps in quantum unit tests

    The patch 5d86e2f2ece51a79102aee2af9a3f306c929aaea
    added wait states into the unit tests for quantum networks, routers and
    ports, but did not stub out the resulting sleep. This caused the tests to
    run for over 1s, which indirectly allowed bug #1182285 to become visible.

    Change-Id: Id26daa87e1618533ee92c33827a9d01800b03752

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.