Quotas code should not raise exceptions when resources are being deleted

Bug #1178285 reported by Nate Bensimon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Steve Leon

Bug Description

Scenario:
1. Set quota for resource (instances or volume) below their current resource usage
2. Delete resource to bring the current usage down

Expected Behavior:
1. Resource is deleted and quota usage is updated accordingly

Actual Behavior:
1. Failure in deleting the resource due to quota check (raises the quota exceeded exception -- 413)

Revision history for this message
Steve Leon (steve-leon) wrote :

Hi Nate,

Thanks for this finding. This happens because the quota calculation runs at a resource gets reserved either for create, delete or update.

We'll look for a fix soon. But the workaround would be to set the quota to a value above the current resource usage and delete again.

Changed in reddwarf:
assignee: nobody → Steve Leon (steve-leon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to reddwarf (master)

Fix proposed to branch: master
Review: https://review.openstack.org/32660

Changed in reddwarf:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/32660
Committed: http://github.com/openstack/trove/commit/51ea4093371ebbf96f391d6dee62356793f201f4
Submitter: Jenkins
Branch: master

commit 51ea4093371ebbf96f391d6dee62356793f201f4
Author: Steve Leon <email address hidden>
Date: Tue Jun 11 17:21:31 2013 -0700

    Fix quota bug where it raises exception when resources are deleted

    - Added an extra check to make sure that if the delta is negative,
      it should not raise an over quota

    fixed bug 1178285

    Change-Id: I23cdc7bfa0a58ee87ae085d51814f73bc9790754

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.