Glance

No unittests around image data upload functionality in api/v1/images.py

Bug #1177999 reported by Alex Meade on 2013-05-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Glance	Fix Released	Low	Alex Meade	Glance 2013.2 "havana"

Bug Description

There are no unittests for the '_upload' function in glance/api/v1/images.py. This function goes a few calls deep on private functions and is a private function itself. This code needs to be reworked and have unittests added.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-05-08: Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/28627

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-05-23: Fix merged to glance (master)

Reviewed: https://review.openstack.org/28627
Committed: http://github.com/openstack/glance/commit/c827b21646b915d34a6696860c7e23892317b2ca
Submitter: Jenkins
Branch: master

commit c827b21646b915d34a6696860c7e23892317b2ca
Author: Alex Meade <email address hidden>
Date: Tue May 7 17:17:30 2013 -0400

Add unittests for image upload functionality in v1

    This patch adds unittests for the code that handles uploading image data to the
    image store in v1 of the api. upload_utils.py was created in order to make this
    area of code more testable and move upload logic out of the images api
    controller.

Fixes bug 1177999

Change-Id: I97f0fa052e65228abb50090af812c3ebec605744