Glance returns dual version strings in 'Location' header when redirecting a '/v#' request

Bug #1175815 reported by James Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
James Li

Bug Description

It looks Bug #1166957 (https://bugs.launchpad.net/glance/+bug/1166957) is not complete.

# curl -i -k https://localhost:9292/v1.1

HTTP/1.1 302 Found
Content-Type: text/plain; charset=utf8
Location: https://localhost:9292/v1.1/v1/ <--------------------------
X-Openstack-Request-Id: req-3afe115d-6d4a-12d4-bc55-df573daf0e22
Content-Length: 0
Date: Thu, 02 May 2013 22:42:37 GMT

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/28217

Changed in glance:
assignee: nobody → James Li (james-li-3)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/28217
Committed: http://github.com/openstack/glance/commit/abbc5353336001572290feb8d06d65094b83a7cf
Submitter: Jenkins
Branch: master

commit abbc5353336001572290feb8d06d65094b83a7cf
Author: James Li <email address hidden>
Date: Fri May 3 22:31:58 2013 +0000

    Redirects requests from /v# to /v#/ with correct Location header

    This is a continuous fix to bug #1166957

    VersionNegotiationFilter pops off the version string of PATH_INFO,
    the popped segment is pushed onto SCRIPT_NAME, which results in
    dual version strings (e.g. '/v1/v1/') in the 'Location' header
    of a redirect response. This may result in a further 404 error
    if the http client will automatically follow the returned
    redirect.

    Fix this problem by adding a private method which does not
    push the popped segment onto SCRIPT_NAME.

    Change-Id: Ie0c244af38534dde2058828fbff840a845cc7c90
    Fixes: bug #1175815

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.