OpenStack DBaaS (Trove)

Requesting bad versions returns a 404 with bad XML / JSON elements.

Bug #1174960 reported by Tim Simpson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Kevin Conway
OpenStack DBaaS (Trove) 2013.2 "havana"

Bug Description

If a request is made for a version that doesn't exist, the output is something like:

"""
404 Not Found

The resource could not be found.
"""

This needs to be some kind of XML or JSON data. Not a biggie, but it would be consistent with other exceptions.

Kevin Conway (kevinconway)
Changed in trove:
assignee: nobody → Kevin Conway (kevinconway)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/33123

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/33123
Committed: http://github.com/openstack/trove/commit/57a10aac00b74a01ff029318f60fc20b8436ebdd
Submitter: Jenkins
Branch: master

commit 57a10aac00b74a01ff029318f60fc20b8436ebdd
Author: Kevin Conway <email address hidden>
Date: Fri Jun 14 16:19:40 2013 -0500

    Fix faulty 404 errors when requesting bad versions

    The problem came down to the `_dispatch` method of the openstack
    common wsgi router object. When a match was not found it returned
    a webob 404 exception directly rather than allowing it to be
    wrapped in a serializer.

    The fix involved extending the `Router` object and reimplementing
    the `_dispatch()` method to use the `Fault` object that serializes
    exceptions.

    Change-Id: I24a590f65ff655b25cfd7d84786df3055af701f1
    Fixes: bug #1174960

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.