neutron

Quota checks in test_extension_pnet not circumvented properly

Bug #1174457 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Salvatore Orlando
neutron 2013.2 "havana"

Bug Description

We had reports that in some cases the just merged unit tests fail.
This is because the plugin is mocked, so at the end of the day get_networks_counts is a mock call, and it gets converted to int in the quota checks.

In some instance, it might return a negative value, leading the InvalidQuotaValue being raised.
The function's return value should be correctly patched.

Tags: unittest
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27738

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/27738
Committed: http://github.com/openstack/quantum/commit/aa6ba83c2046e35ccfdafa3641d17a3b26859cf7
Submitter: Jenkins
Branch: master

commit aa6ba83c2046e35ccfdafa3641d17a3b26859cf7
Author: Salvatore Orlando <email address hidden>
Date: Mon Apr 29 20:20:12 2013 +0200

    Stub out get_networks_count properly for pnet unit tests

    Bug 1174457

    Change-Id: I30a5c549d5d236124a7798a757601e970067b284

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.