OpenStack Heat

Error when listing a stack that contains a Number parameter

Bug #1160653 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steve Baker
OpenStack Heat 2013.1 "grizzly"

Bug Description

Launching WordPress_2_Instances_With_EBS.template and running 'heat list' results in the following error being logged

2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp File "/home/steveb/dev/localstack/heat/heat/engine/service.py", line 181, in list_stacks
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp return list(format_stack_details(stacks))
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp File "/home/steveb/dev/localstack/heat/heat/engine/service.py", line 178, in format_stack_details
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp yield api.format_stack(stack)
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp File "/home/steveb/dev/localstack/heat/heat/engine/api.py", line 76, in format_stack
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp STACK_PARAMETERS: stack.parameters.map(str),
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp File "/home/steveb/dev/localstack/heat/heat/engine/parameters.py", line 273, in map
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp for n, p in self.params.iteritems() if filter_func(p))
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp File "/home/steveb/dev/localstack/heat/heat/engine/parameters.py", line 273, in <genexpr>
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp for n, p in self.params.iteritems() if filter_func(p))
2013-03-27 13:31:05.254 8054 TRACE heat.openstack.common.rpc.amqp TypeError: __str__ returned non-string (type int)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25476

Changed in heat:
assignee: nobody → Steve Baker (steve-stevebaker)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/25476
Committed: http://github.com/openstack/heat/commit/b76eb46fdeb3431b5220dd909334ba64b7a2515b
Submitter: Jenkins
Branch: master

commit b76eb46fdeb3431b5220dd909334ba64b7a2515b
Author: Steve Baker <email address hidden>
Date: Wed Mar 27 13:35:54 2013 +1300

    Don't assume a Parameter value is a str

    Currently show_stack and list_stacks will fail for templates
    which have a Number in the Parameters.

    This should be considered for backport to milestone_proposed.

    Change-Id: I1b20babf0998f7714f8bc7bf144e03ff1d7c0c91
    Fixes: bug #1160653

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → grizzly-rc2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25629

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (milestone-proposed)

Reviewed: https://review.openstack.org/25629
Committed: http://github.com/openstack/heat/commit/e72608459424869a36c109637a159a49866557a9
Submitter: Jenkins
Branch: milestone-proposed

commit e72608459424869a36c109637a159a49866557a9
Author: Steve Baker <email address hidden>
Date: Wed Mar 27 13:35:54 2013 +1300

    Don't assume a Parameter value is a str

    Currently show_stack and list_stacks will fail for templates
    which have a Number in the Parameters.

    This should be considered for backport to milestone_proposed.

    Change-Id: I1b20babf0998f7714f8bc7bf144e03ff1d7c0c91
    Fixes: bug #1160653
    (cherry picked from commit b76eb46fdeb3431b5220dd909334ba64b7a2515b)

Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-rc2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.