OpenStack Heat

Resources not deleted after a failed update

Bug #1151989 reported by Steven Hardy on 2013-03-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Heat	Fix Released	High	Steven Hardy	OpenStack Heat 2013.1 "grizzly"

Bug Description

When doing a stack update, if you add new resources, and they fail on creation, then those failed resources are not cleaned up on stack deletion.

An easy way to reproduce this is to create a stack, then do an update which adds an additional instance, which has an associated waitcondition with a very short timeout - the waitcondition will timeout, leaving the new instance in CREATE_FAILED state, so the update will fail, then when you delete the stack the new failed instance will not be correctly removed.

Steven Hardy (shardy) on 2013-03-07

Changed in heat:
status:	New → Triaged
importance:	Undecided → High
assignee:	nobody → Steven Hardy (shardy)
milestone:	none → grizzly-rc1

Steven Hardy (shardy) on 2013-03-08

Changed in heat:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-08: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23940

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-10: Fix merged to heat (master)

Reviewed: https://review.openstack.org/23940
Committed: http://github.com/openstack/heat/commit/b8aad78cc5389874056de547dcd26a198a3bbd03
Submitter: Jenkins
Branch: master

commit b8aad78cc5389874056de547dcd26a198a3bbd03
Author: Steven Hardy <email address hidden>
Date: Fri Mar 8 17:23:17 2013 +0000

heat engine : store stack on failed update

    Store the stack even when the update fails, otherwise we
    lose track of the resources which failed on create so they
    are not removed on stack delete

fixes bug 1151989

Change-Id: Ic8aa5ef92e188fb704ed25563aa9b86aa69232b4