OpenStack Heat

API policy debug logging is too noisy

Bug #1150091 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Steven Hardy
OpenStack Heat 2013.1 "grizzly"

Bug Description

The debug output from heat.common.policy prints the loaded policy for every request to the CFN/CW API's, should probably quieten this down:

2013-03-06 18:22:03.655 3590 DEBUG heat.common.policy [-] Loaded policy rules: {u'cloudformation:ListStacks': 'rule:deny_stack_user', u'cloudwatch:DisableAlarmActions': 'rule:deny_stack_user', u'cloudformation:DescribeStackResources': 'rule:deny_stack_user', u'cloudformation:DescribeStackResource': '@', u'cloudformation:EstimateTemplateCost': 'rule:deny_stack_user', u'cloudformation:GetTemplate': 'rule:deny_stack_user', u'deny_stack_user': 'not role:heat_stack_user', u'cloudformation:ListStackResources': 'rule:deny_stack_user', u'cloudwatch:PutMetricAlarm': 'rule:deny_stack_user', u'cloudwatch:DescribeAlarmHistory': 'rule:deny_stack_user', u'cloudwatch:GetMetricStatistics': 'rule:deny_stack_user', u'cloudformation:CreateStack': 'rule:deny_stack_user', u'cloudformation:DescribeStacks': 'rule:deny_stack_user', u'cloudwatch:SetAlarmState': 'rule:deny_stack_user', u'cloudwatch:ListMetrics': 'rule:deny_stack_user', u'cloudformation:ValidateTemplate': 'rule:deny_stack_user', u'cloudwatch:PutMetricData': '@', u'cloudwatch:EnableAlarmActions': 'rule:deny_stack_user', u'cloudformation:DescribeStackEvents': 'rule:deny_stack_user', u'cloudwatch:DeleteAlarms': 'rule:deny_stack_user', u'cloudformation:UpdateStack': 'rule:deny_stack_user', u'cloudwatch:DescribeAlarmsForMetric': 'rule:deny_stack_user', u'cloudformation:DeleteStack': 'rule:deny_stack_user', u'cloudwatch:DescribeAlarms': 'rule:deny_stack_user'} load_rules /usr/lib/python2.7/site-packages/heat-2013.1.a310.gb8b5624-py2.7.egg/heat/common/policy.py:73

Steven Hardy (shardy)
Changed in heat:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Steven Hardy (shardy)
milestone: none → grizzly-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23801

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/23802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/23801
Committed: http://github.com/openstack/heat/commit/52035468bb6e721e16ca41c85bbb359f9efb6b40
Submitter: Jenkins
Branch: master

commit 52035468bb6e721e16ca41c85bbb359f9efb6b40
Author: Steven Hardy <email address hidden>
Date: Thu Mar 7 11:12:20 2013 +0000

    heat common : policy.py change LOG to logger

    The convention in most other files is to use "logger" for the
    log handle, so this file using "LOG" looks a bit odd/inconsistent

    ref bug 1150091

    Change-Id: I159ad59dfaa3a1db36aad11cb6ce9625f1105c51

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/23802
Committed: http://github.com/openstack/heat/commit/ed77bb268d3b4aa4beed5b358135cc489105c188
Submitter: Jenkins
Branch: master

commit ed77bb268d3b4aa4beed5b358135cc489105c188
Author: Steven Hardy <email address hidden>
Date: Thu Mar 7 11:14:45 2013 +0000

    heat common : quieten policy logging

    Policy logs the currently loaded policy for every request, which is
    too noisy even for debug - we already log the file which contains
    the policy when we load it, so this is probably sufficient.

    fixes bug 1150091

    Change-Id: I0891a30793375c7a0a6b2856db4377eecfeaad8e

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.