OpenStack Heat

Autoscaling/InstanceGroup instances are created serially

Bug #1136148 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Zane Bitter
OpenStack Heat 2013.1 "grizzly"

Bug Description

There is no point in the AutoscalingGroup or InstanceGroup waiting for each instance to reach the ACTIVE state before creating the next one. We should create all required instances at the beginning and only then block until they are all complete.

Zane Bitter (zaneb)
Changed in heat:
assignee: nobody → Zane Bitter (zaneb)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23287

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/23287
Committed: http://github.com/openstack/heat/commit/8dfd53db24610b5c534ab165328ddfb6927deff9
Submitter: Jenkins
Branch: master

commit 8dfd53db24610b5c534ab165328ddfb6927deff9
Author: Zane Bitter <email address hidden>
Date: Mon Mar 4 11:31:27 2013 +0100

    Create autoscaling instances in parallel

    Fixes bug #1136148

    Change-Id: I02ea52df85c4ed7f0f16abcfd1ab24b35168a787
    Signed-off-by: Zane Bitter <email address hidden>

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25540

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/25540
Committed: http://github.com/openstack/heat/commit/2ac3b8b8742c05fc5faf2295b5d00f4f12b4aab9
Submitter: Jenkins
Branch: master

commit 2ac3b8b8742c05fc5faf2295b5d00f4f12b4aab9
Author: Steven Hardy <email address hidden>
Date: Wed Mar 27 16:08:41 2013 +0000

    heat engine : Autoscaling reload Loadbalancer correctly

    Since the change implemented as part of bug #1136148 we no longer
    wait for nova to create the instance before reloading the loadbalancer
    which means we race nova assigning an IP to the instance and typically
    the loadbalancer config ends up with the 0.0.0.0 default value
    which the loadbalancer implementation uses when nova returns no IP.

    This patch moves the LB reload into a separate function, which is called
    after instances are active on group creation or adjustment

    Since our loadbalancer is broken without this fix, this is a candidate
    for backporting to grizzly milestone-proposed.

    fixes bug #1160407

    Change-Id: I50423883dead9a615aa79b8765d5480a9345686d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25600

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (milestone-proposed)

Reviewed: https://review.openstack.org/25600
Committed: http://github.com/openstack/heat/commit/1ac1f895132f2dcbab67025fbc7309b0efeccd28
Submitter: Jenkins
Branch: milestone-proposed

commit 1ac1f895132f2dcbab67025fbc7309b0efeccd28
Author: Steven Hardy <email address hidden>
Date: Wed Mar 27 16:08:41 2013 +0000

    heat engine : Autoscaling reload Loadbalancer correctly

    Since the change implemented as part of bug #1136148 we no longer
    wait for nova to create the instance before reloading the loadbalancer
    which means we race nova assigning an IP to the instance and typically
    the loadbalancer config ends up with the 0.0.0.0 default value
    which the loadbalancer implementation uses when nova returns no IP.

    This patch moves the LB reload into a separate function, which is called
    after instances are active on group creation or adjustment

    Since our loadbalancer is broken without this fix, this is a candidate
    for backporting to grizzly milestone-proposed.

    fixes bug #1160407

    Change-Id: I50423883dead9a615aa79b8765d5480a9345686d

Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.