oslo-incubator

Excepthook Tests shouldn't use subprocess

Bug #1124617 reported by Jason Kölker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Wishlist
Jason Kölker
oslo-incubator grizzly-3 "g3"
Grizzly
Fix Released
Wishlist
Jason Kölker
oslo-incubator 2013.1 "grizzly"

Bug Description

While working on a LoggerAdapter to allow kwargs I stumbled across this test https://review.openstack.org/#/c/10611/2/tests/unit/test_log.py

This can be rewritten to not use subprocess and ensure that the excepthook is not python's default.

Jason Kölker (jason-koelker)
Changed in oslo:
importance: Undecided → Wishlist
assignee: nobody → Jason Kölker (jason-koelker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21918

Changed in oslo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/21918
Committed: http://github.com/openstack/oslo-incubator/commit/449ddfc682ff75964f659da97c3eb3de7596a439
Submitter: Jenkins
Branch: master

commit 449ddfc682ff75964f659da97c3eb3de7596a439
Author: Jason Kölker <email address hidden>
Date: Wed Feb 13 16:57:56 2013 -0600

    Don't use subprocess for testing excepthook

    * The previous test tested the funtionality of the excepthook using
      subprocess.popen. We don't need to test the interpreter, just test
      that our excepthook is installed and test that it functions as expected.
    * Fix Bug 1124617

    Change-Id: Ifd8d35b842b913003100097d917d30bf66e5cb7a

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.