The dash closes when trying to switch from Command lens to home lens
Bug #1108956 reported by
Romain Perier
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Committed
|
Low
|
John Lea | ||
Unity |
Fix Released
|
Low
|
Brandon Schaefer | ||
7.2 |
Triaged
|
Low
|
Brandon Schaefer | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Brandon Schaefer |
Bug Description
When I open the command lens by pressing ALT+F2, if I press "Super" the dash is closed. It should not be closed, it should switch to the home lens instead. This is the suite of the bug 1019457
Related branches
lp://staging/~rperier/unity/command-lens-switching
Superseded
for merging
into
lp://staging/unity
- Łukasz Zemczak (community): Needs Fixing
-
Diff: 52 lines (+11/-2)3 files modifieddash/DashView.cpp (+4/-1)
dash/LensBar.h (+2/-1)
tests/autopilot/unity/tests/test_dash.py (+5/-0)
lp://staging/~brandontschaefer/unity/lp.1108956-fix
- PS Jenkins bot (community): Approve (continuous-integration)
- Andrea Azzarone (community): Approve
- Łukasz Zemczak: Pending requested
-
Diff: 65 lines (+21/-3)3 files modifieddash/DashView.cpp (+9/-2)
dash/LensBar.h (+2/-1)
tests/autopilot/unity/tests/test_dash.py (+10/-0)
lp://staging/~brandontschaefer/unity/lp.1108956-fix-again
On hold
for merging
into
lp://staging/unity
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 75 lines (+27/-5)3 files modifieddash/DashView.cpp (+11/-4)
tests/autopilot/unity/emulators/dash.py (+6/-1)
tests/autopilot/unity/tests/test_dash.py (+10/-0)
lp://staging/~brandontschaefer/unity/command-to-dash-fix
- Stephen M. Webb (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Christopher Townsend (community): Approve
-
Diff: 29 lines (+7/-1)2 files modifiedplugins/unityshell/src/unityshell.cpp (+6/-0)
tests/autopilot/unity/emulators/dash.py (+1/-1)
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Low |
status: | New → Fix Committed |
tags: | added: udp |
Changed in unity: | |
importance: | Undecided → Low |
Changed in unity: | |
status: | New → Fix Committed |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in unity: | |
status: | Fix Committed → In Progress |
milestone: | none → 7.0.0 |
Changed in unity (Ubuntu): | |
importance: | Undecided → Low |
Changed in unity: | |
assignee: | Romain Perier (rperier) → Brandon Schaefer (brandontschaefer) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
milestone: | 7.0.1 → 7.1.1 |
Changed in unity: | |
milestone: | 7.1.1 → 7.2.0 |
Changed in unity: | |
status: | In Progress → Triaged |
Changed in unity (Ubuntu): | |
status: | In Progress → Confirmed |
Changed in unity: | |
milestone: | 7.2.0 → 7.2.1 |
Changed in unity: | |
milestone: | 7.2.1 → 7.2.2 |
Changed in unity: | |
milestone: | 7.2.2 → 7.2.3 |
Changed in unity: | |
milestone: | 7.2.3 → 7.3.1 |
Changed in unity: | |
milestone: | 7.3.1 → 7.3.2 |
Changed in unity: | |
milestone: | 7.3.2 → 7.3.3 |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
What I suggest:
1. Put LensBar: :getActiveLensI d() public cpp:OnActivateR equest
2. Use the previous method to get the current lens id from dash/DashView.
3. If the dash if visible && the event is of type NOT_HANDLED && the new lens id is != the current lens id : switch to the lens instead of closing the dash, otherwise close the dash.