Instances can be deleted while in BUILD state

Bug #1101380 reported by Robert Myers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Robert Myers

Bug Description

During instance deletion the check to see if the instance is building is incomplete. The BaseInstance should defer to the superclass 'is_building' property rather than duplicating the check.

If the Instance is still building then a delete could be issued before
it is complete causing the removal of the record from the instances
database, leaving an orphaned instance.

Robert Myers (rmyers)
Changed in reddwarf:
importance: Undecided → Medium
assignee: nobody → Robert Myers (rmyers)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to reddwarf (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20054

Changed in reddwarf:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to reddwarf (master)

Reviewed: https://review.openstack.org/20054
Committed: http://github.com/stackforge/reddwarf/commit/d8d50aafd85be3e95df6ca8c284fdd17d3acbc5b
Submitter: Jenkins
Branch: master

commit d8d50aafd85be3e95df6ca8c284fdd17d3acbc5b
Author: Robert Myers <email address hidden>
Date: Fri Jan 18 15:26:52 2013 -0600

    Fixing race condition during instance deletion.

    Defer to the superclass to check if the instance is building
    which handles more edge cases. This will prevent the instance
    from being deleted while it is still being built.

    Change-Id: I35b71931c7eec0ab7dfcec46f2ed4500f8803281
    Fixes: bug #1101380

Changed in reddwarf:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.