Logic in rest_client.py is incorrect
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tempest |
Fix Released
|
High
|
Rajalakshmi Ganesan |
Bug Description
The code in rest_client.py related to 413 error code seems to be incorrect. Following is the logic when return code for request is 413:
if resp.status == 413:
if 'overLimit' in resp_body:
elif 'limit' in resp_body[
elif depth < MAX_RECURSION_
else:
I understand the first two conditions ['overLimit' in resp_body] and ['limit' in resp_body[
Thus No Retry is occurring when rate-limit is encountered. The flow gets stopped at second condition itself.
Hence removal of condition second condition (that checks "limit"word in response mesage) would be appropriate. Due to this logic in rest_client.py, tests script that encounters rate-limit fails in the first attempt without re-try.
Changed in tempest: | |
importance: | Undecided → High |
Changed in tempest: | |
milestone: | none → havana-3 |
Fix proposed to branch: master /review. openstack. org/18655
Review: https:/