oslo-incubator

empty args to zmq cast/call methods errors

Bug #1089750 reported by Erica Windisch on 2012-12-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	oslo-incubator	Fix Released	Medium	Erica Windisch	oslo-incubator grizzly-2 "g2"
	Grizzly	Fix Released	Medium	Erica Windisch	oslo-incubator 2013.1 "grizzly"

Bug Description

If the payload of an rpc request is missing 'args' and one is using the zeromq driver, args was being set to an empty list, rather than an empty dict, causing an error.

Reported by Jean-Christophe Smith and Yosef Berman.

See original description

Erica Windisch (ewindisch) on 2012-12-13

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-12-13: Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18002

Changed in oslo:
assignee:	nobody → Eric Windisch (ewindisch)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-01-08: Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/18002
Committed: http://github.com/openstack/oslo-incubator/commit/1e6b9b7bc7ed3430c442c6bc075ec541850f495d
Submitter: Jenkins
Branch: master

commit 1e6b9b7bc7ed3430c442c6bc075ec541850f495d
Author: Eric Windisch <email address hidden>
Date: Wed Dec 12 22:19:18 2012 -0500

rpc method arguments should be dict, not list

    default arguments were being set to a
    list instead of a dict. This caused
    problems if the args key was missing
    in the msg argument to the call/cast methods.

    Adds tests to check if RPC cast/call work
    without arguments. Changes and documents
    the _test_cast method arguments, allowing
    for more flexibility and code reuse.

fixes bug 1089750

Change-Id: I854dc3fcad8936695feb4414f3862672cf98c5d1