sendfile possibly problematic with eventlet

Bug #1087530 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steve Baker
Grizzly
Fix Released
Medium
Steve Baker

Bug Description

Pysendfile contains sendfilemodule.c which appears to do IO. This has potential to cause blocking issues with eventlet green threads.

Its only used in heat.common.BaseClient, and it appears to be optional.

For these reasons I'd like to suggest ripping it out.

Changed in heat:
milestone: none → grizzly-3
assignee: nobody → Steve Baker (steve-stevebaker)
Steven Dake (sdake)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21184

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/21184
Committed: http://github.com/openstack/heat/commit/d2528a5222bd76cdaa8f4ab826134e2f9fe14c15
Submitter: Jenkins
Branch: master

commit d2528a5222bd76cdaa8f4ab826134e2f9fe14c15
Author: Steve Baker <email address hidden>
Date: Tue Feb 5 16:15:13 2013 +1300

    Remove sendfile as a dependency.

    This is dead code anyway, since heat-cfn doesn't handle large binary files like glance.

    Fixes bug 1087530

    Change-Id: Iaba7adce088b20136ece0828d4085679fcbab731

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.