Dash and HUD do not have X event focus, causing XIM to not work.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
High
|
Brandon Schaefer | ||
| unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
When the Dash or HUD is open the Launcher has X event focus. This means XIM will not work with either because the events generated are ment for the Dash or HUD not the Launcher.... Here is the bit of offending code:
unityshell.
// We do this after the notify to ensure input focus has actually been moved.
if (n == CompWindowNotif
{
UnityScreen* us = UnityScreen:
CompWindow *lw;
// can't rely on launcher-
if (us && (us->dash_
{
lw = screen-
lw-
}
}
Ill have to look into a good soultion to this problem...as the point of this code is to avoid losing focus of the Dash or HUD when an external program is opened...So this regession needs to be avoided. (And no you can't simply refocus the dash or hud, that doesn't give key focus back...)
Related branches
- Andrea Azzarone (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 218 lines (+59/-27)6 files modifieddash/DashController.cpp (+22/-9)
dash/DashController.h (+4/-0)
hud/HudController.cpp (+20/-8)
hud/HudController.h (+3/-0)
plugins/unityshell/src/unityshell.cpp (+10/-5)
tests/autopilot/unity/tests/xim/test_gcin.py (+0/-5)
| Changed in unity: | |
| importance: | Undecided → High |
| assignee: | nobody → Brandon Schaefer (brandontschaefer) |
| milestone: | none → 7.0.0 |
| status: | New → Confirmed |
| description: | updated |
| Changed in unity: | |
| status: | Confirmed → In Progress |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity (Ubuntu): | |
| status: | New → Fix Released |
| Stephen M. Webb (bregma) wrote | #2 |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package unity - 6.12.0daily13.
---------------
unity (6.12.0daily13.
[ Didier Roche ]
* debian/control:
- bump some missed build-deps
- bump compiz and nux build-deps for the API and ABI breakages
(LP: #1095981)
* debian/rules:
- disable pch for now as it's not working with -g -02 (LP: #1095978)
[ Brandon Schaefer ]
* Ported Compiz to 0.9.9
* debian/control:
- bump the build-deps
* Dash and HUD do not have X event focus, causing XIM to not work.
(LP: #1086988)
* Windows losing focus after the start/restart of Unity (LP: #1097368)
[ Łukasz 'sil2100' Zemczak ]
* Dash - Update Dash nav bar icons (LP: #1089373)
* Autopilot tests failing in the test_hud suite due to locale
dependency (LP: #1076531)
* Super key not registered if held too long (LP: #1097189)
* Unity HUD uses wrong icon when switching from the Dash to HUD (LP:
#1089482)
[ Marco Trevisan (Treviño) ]
* Using bleeding edge Mesa drivers causes GL_INVALID_
in glDrawBuffer / glReadBuffer (LP: #1092550)
* [Regression] Window buttons / Title doesn't redraw correctly on
windows with no menus (LP: #1090439)
[ Nick Dedekind ]
* Dash - When the Dash preview is open, the ghost images should run
all the way to the top of the screen as shown in the design (LP:
#1060948)
* Dash - When the Dash preview opens, the category headers should be
expanded and the filters should hide (LP: #1060937)
* Dash - In the Dash preview, when a user moves to the next or
previous preview the highlighted ghost image should change (LP:
#1060941)
* Dash - As soon as a user starts dragging a .png file from the Dash,
the file icon changes size (LP: #863412)
[ Gord Allott <email address hidden>, Łukasz 'sil2100' Zemczak <email address hidden>, Didier Roche ]
* "unitydashlegal
* unity dash should show legal disclaimer (LP: #1065652)
[ Manuel de la Pena ]
* StaticCairoText makes NUX get into an infinte loop (LP: #1071327)
[ Daniel van Vugt ]
* Minimized windows don't restore, or restore as blank (LP: #1089779)
[ Andrea Azzarone ]
* TestOverlayScro
* Dash - Update Dash Launcher icon tooltip to say "Search your
computer and online sources" (LP: #1090325)
* TestLauncherCon
segfaults (LP: #1089894)
* TestDashControl
* [Regression] Tapping super key shows shortcuts overlay. (LP:
#1090388)
* [Regression] Unity fails to restore initially minimized windows.
(LP: #1097686)
* launcher does not show minimized update manager while clicked (LP:
#1003950)
* Dash - Update Dash Home search box hint message to say "Search your
computer and online sources" (LP: #1090327)
* can't quit a minimized application (LP: #1086366)
* Unity daily-build (07.01.13) empty space between launcher and dash
in non default launcher size (LP: #1097184)
[ Sam Spilsbury ]
* Fonts get chang...