cast_to_server broken for impl_qpid

Bug #1086848 reported by Russell Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
High
Russell Bryant
Grizzly
Fix Released
High
Russell Bryant

Bug Description

$ nosetests tests/unit/rpc/test_qpid.py
test_call (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_cast (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_cast_to_server (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ERROR
test_create_connection (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_create_consumer (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_create_consumer_fanout (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_create_worker (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_fanout_cast (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_fanout_cast_to_server (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ERROR
test_multicall (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok
test_topic_consumer (tests.unit.rpc.test_qpid.RpcQpidTestCase) ... ok

======================================================================
ERROR: test_cast_to_server (tests.unit.rpc.test_qpid.RpcQpidTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/testutils.py", line 51, in _skipper
    func(*args, **kw)
  File "/home/rbryant/src/openstack/oslo-incubator/tests/unit/rpc/test_qpid.py", line 306, in test_cast_to_server
    self._test_cast(fanout=False, server_params=server_params)
  File "/home/rbryant/src/openstack/oslo-incubator/tests/unit/rpc/test_qpid.py", line 269, in _test_cast
    method(*args)
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/rpc/impl_qpid.py", line 568, in cast_to_server
    rpc_amqp.get_connection_pool(conf, Connection))
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/rpc/amqp.py", line 395, in cast_to_server
    server_params=server_params) as conn:
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/rpc/amqp.py", line 99, in __init__
    server_params=server_params)
  File "/home/rbryant/src/openstack/oslo-incubator/tests/unit/rpc/test_qpid.py", line 292, in __init__
    self.assertEqual(myself.broker,
AttributeError: 'MyConnection' object has no attribute 'broker'
-------------------- >> begin captured logging << --------------------
openstack.common.rpc.impl_qpid: INFO: Connected to AMQP server on localhost:5672
--------------------- >> end captured logging << ---------------------

======================================================================
ERROR: test_fanout_cast_to_server (tests.unit.rpc.test_qpid.RpcQpidTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/testutils.py", line 51, in _skipper
    func(*args, **kw)
  File "/home/rbryant/src/openstack/oslo-incubator/tests/unit/rpc/test_qpid.py", line 315, in test_fanout_cast_to_server
    self._test_cast(fanout=True, server_params=server_params)
  File "/home/rbryant/src/openstack/oslo-incubator/tests/unit/rpc/test_qpid.py", line 269, in _test_cast
    method(*args)
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/rpc/impl_qpid.py", line 575, in fanout_cast_to_server
    rpc_amqp.get_connection_pool(conf, Connection))
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/rpc/amqp.py", line 404, in fanout_cast_to_server
    server_params=server_params) as conn:
  File "/home/rbryant/src/openstack/oslo-incubator/openstack/common/rpc/amqp.py", line 99, in __init__
    server_params=server_params)
  File "/home/rbryant/src/openstack/oslo-incubator/tests/unit/rpc/test_qpid.py", line 292, in __init__
    self.assertEqual(myself.broker,
AttributeError: 'MyConnection' object has no attribute 'broker'
-------------------- >> begin captured logging << --------------------
openstack.common.rpc.impl_qpid: INFO: Connected to AMQP server on localhost:5672
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 11 tests in 0.014s

FAILED (errors=2)

Tags: qpid rpc
Revision history for this message
Mark McLoughlin (markmc) wrote :
tags: added: qpid rpc
Changed in oslo:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Russell Bryant (russellb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/17541
Committed: http://github.com/openstack/oslo-incubator/commit/3f8df660030a078db2c295e7ae74a32c88c7af02
Submitter: Jenkins
Branch: master

commit 3f8df660030a078db2c295e7ae74a32c88c7af02
Author: Russell Bryant <email address hidden>
Date: Wed Dec 5 10:35:25 2012 -0500

    Fix qpid cast_to_server regression.

    This patches addresses a regression in the qpid driver for the
    cast_to_server and fanout_cast_to_server methods. The regression was
    introduced in 86952852c1dadd54f1294ae0adba01cfe827b8ce.

    There are test cases that cover this code, but unfortunately they are
    not being run by jenkins because python-qpid is not available in pypi.

    Fix bug 1086848.

    Change-Id: I89d4f81149f9a05c578b5ec544c5e34311484c6c

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.