[Upstream] Endnote placed at end of document is unmovable

Created attachment 71810
Endnotes 2 test files (word and wordperfect formats)

Endnotes always start on a new page.
This should definitely NOT be the case.
It should be possible to have endnotes on the same page as the end of the document, as it is the case with MS Word and Corel WordPerfect.
===
Better still, it should be possible to have endnotes at different places, for exemple if you have several articles and want endnotes for each.
This is possible with WordPerfect, apparently not with Word.

Created attachment 71810
Endnotes 2 test files (word and wordperfect formats)

Endnotes always start on a new page.
This should definitely NOT be the case.
It should be possible to have endnotes on the same page as the end of the document, as it is the case with MS Word and Corel WordPerfect.
===
Better still, it should be possible to have endnotes at different places, for exemple if you have several articles and want endnotes for each.
This is possible with WordPerfect, apparently not with Word.

Reproducible in:
Microsoft Windows Vista Business x86
6.0.6002 Service Pack 2 Build 6002
Version 4.0.0.0.beta1 (Build ID: 87906242e87d3ddb2ba9827818f2d1416d80cc7)

Reproducible in:
Microsoft Windows Vista Business x86
6.0.6002 Service Pack 2 Build 6002
Version 4.0.0.0.beta1 (Build ID: 87906242e87d3ddb2ba9827818f2d1416d80cc7)

*** Bug 66121 has been marked as a duplicate of this bug. ***

*** Bug 66121 has been marked as a duplicate of this bug. ***

Workaround: Highlight all text prior to the footnotes and insert a section. Use the Endnote option "Collect at end of section". This is however only effective for ODT and not DOC or DOCX. Summary amended to reflect this fact and the format of the provided example.

Workaround: Highlight all text prior to the footnotes and insert a section. Use the Endnote option "Collect at end of section". This is however only effective for ODT and not DOC or DOCX. Summary amended to reflect this fact and the format of the provided example.

Le 21. 04. 14 03:55, <email address hidden> a écrit :
> Owen Genat <mailto:<email address hidden>> changed bug 58521
> <https://bugs.freedesktop.org/show_bug.cgi?id=58521>
> What Removed Added
> Summary Endnotes always start on a new page. Endnotes always start
> on a new page (DOC/DOCX)
>
> *Comment # 3 <https://bugs.freedesktop.org/show_bug.cgi?id=58521#c3>
> on bug 58521 <https://bugs.freedesktop.org/show_bug.cgi?id=58521> from
> Owen Genat <mailto:<email address hidden>> *
> Workaround: Highlight all text prior to the footnotes and insert a section. Use
> the Endnote option "Collect at end of section". This is however only effective
> for ODT and not DOC or DOCX. Summary amended to reflect this fact and the
> format of the provided example.
> ------------------------------------------------------------------------
> You are receiving this mail because:
>
> * You reported the bug.
>
Thanks a lot. It works!

Le 21. 04. 14 03:55, <email address hidden> a écrit :
> Owen Genat <mailto:<email address hidden>> changed bug 58521
> <https://bugs.freedesktop.org/show_bug.cgi?id=58521>
> What Removed Added
> Summary Endnotes always start on a new page. Endnotes always start
> on a new page (DOC/DOCX)
>
> *Comment # 3 <https://bugs.freedesktop.org/show_bug.cgi?id=58521#c3>
> on bug 58521 <https://bugs.freedesktop.org/show_bug.cgi?id=58521> from
> Owen Genat <mailto:<email address hidden>> *
> Workaround: Highlight all text prior to the footnotes and insert a section. Use
> the Endnote option "Collect at end of section". This is however only effective
> for ODT and not DOC or DOCX. Summary amended to reflect this fact and the
> format of the provided example.
> ------------------------------------------------------------------------
> You are receiving this mail because:
>
> * You reported the bug.
>
Thanks a lot. It works!

I also ran into this bug when importing a RTF document that contained Endnotes. It's likely an issue with many document formats besides .doc and .docx.

I also ran into this bug when importing a RTF document that contained Endnotes. It's likely an issue with many document formats besides .doc and .docx.

Miklos,
You've done a lot of work on RTF and DOCX importer lately, so I CC'd you to raise your attention to this issue. Feel free to remove.

Miklos,
You've done a lot of work on RTF and DOCX importer lately, so I CC'd you to raise your attention to this issue. Feel free to remove.

Created attachment 106978
Sample DOCX file showing issue with endnotes

Created attachment 106978
Sample DOCX file showing issue with endnotes

Created attachment 106979
Sample RTF file showing issue with endnotes

Created attachment 106979
Sample RTF file showing issue with endnotes

Looks like a duplicate of Bug 36021.

*** Bug 104415 has been marked as a duplicate of this bug. ***

*** Bug 97675 has been marked as a duplicate of this bug. ***

Justin,
I noticed you're working in this area. Is this something you could take a look at?

As Owen Genat noted in comment #3, this can be accomplished in ODF by inserting a section. However, by default, a section doesn't seem to be used for the main document. Most of the duplicates are asking for this option without using sections, and that would certainly simplify cross-compatibility with docx/rtf etc.

This kind of major adjustment needs to be done by someone with a good overview of writer - not me.

Perhaps if it was visible the pagebreak to users, they would simply be able to extract it. It's just an idea. I'm not a developer, just a user. :)

Repro on:
Version: 6.5.0.0.alpha0+ (x64)
Build ID: 0faf74a58847a4b87ae43092fe1ca2011bbd1f90
CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: GL; VCL: win;
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

I strongly support the OP's request to be able to add endnotes at the end of the document (without having to create a section first, and without a page break).

this is fixed with resolving bug 124601

*** This bug has been marked as a duplicate of bug 124601 ***

(In reply to Cor Nouws from comment #17)
> this is fixed with resolving bug 124601
This has to be a mistake. That bug has nothing to do with endnotes.

(In reply to Justin L from comment #18)
> This has to be a mistake. That bug has nothing to do with endnotes.
Must have been confused - sorry.

*** Bug 129036 has been marked as a duplicate of this bug. ***

A compatibility option was added for DOC format here that could be adapted to DOCX/RTF too: https://bugs.documentfoundation.org/show_bug.cgi?id=124601#c8

*** Bug 134824 has been marked as a duplicate of this bug. ***

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f9982c24066d6dd2f938cc20176af0f196bc018f

tdf#58521 DOCX import: enable ContinuousEndnotes compat flag

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/e35fc16969c0d0a55538733d76fc4bb03bf137b0

tdf#58521 DOCX import: enable ContinuousEndnotes compat flag

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Created attachment 173560
RTF attachment 106979 in Word and Writer

RTF is still bad in todays nightly:

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 213430e0bdac0786b30a76a68b43d35647e93912
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL Jumbo

Did you try moving the ContinuousEndnotes opt-in from writerfilter/source/filter/WriterFilter.cxx to writerfilter/source/dmapper/DomainMapper.cxx?

The first is the place for docx-only compat flags, the second is the place for docx+rtf compat flags.

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/892488b64f09190896d5a14e3f555ca91b3449e3

tdf#58521 Enable ContinuousEndnotes compat option for RTF too

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/59c5732875c1bea619ed461a378906a2dce12b48

tdf#58521 Enable ContinuousEndnotes compat option for RTF too

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Any reason this is still open?
Please add to https://wiki.documentfoundation.org/ReleaseNotes/7.2.

I opened a similar request of enhancement, that was linked to this bug.

I requested to manage endnotes like an index:
- defining where put the index
- defining the title
- be able to add pages (with different style) before and after the endnotes

The solution released improves the endnotes handling, but the list of endnotes is always at end of the document, I can't add a page and there are no protections against accidental formatting corruption.

Finally which is the difference between endnotes and footnotes displayed at the end of document?

(In reply to Do from comment #30)
> I opened a similar request of enhancement, that was linked to this bug.

Then let's undo the duplicate status of your report

Created attachment 173801
Writer document showing endnotes

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: c703b2d22c3f45825d9c9d790c3b5a4b6f97e776
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-17_00:44:32
Calc: threaded

See attacher Writer file (endnotes_test_document). AFAICS, nothing has been fixed at all. Endnotes are STILL inserted on a new page at the end of a document, and there seems to be no no way of positioning them at any other location.

And importing the test documents (from the OP) does not seem to be resolved either. The endnotes are simply being dumped as a single set of de facto footnotes at the end of the file.

(In reply to R. Green from comment #32)
> Created attachment 173801 [details]
> Writer document showing endnotes
>
> Version: 7.3.0.0.alpha0+ / LibreOffice Community
> Build ID: c703b2d22c3f45825d9c9d790c3b5a4b6f97e776
> CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
> Locale: en-GB (en_GB.UTF-8); UI: en-US
> TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
> 2021-06-17_00:44:32
> Calc: threaded

Your build is 1 month too old, please pay attention to the build date.

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/7eb0b5f3861e54ad59897315b17bf4447fabf540

Revert "tdf#58521 Enable ContinuousEndnotes compat option for RTF too"

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/43d2b3bbacdd6bbe24149ed33c54a180d74c77e4

Revert "tdf#58521 DOCX import: enable ContinuousEndnotes compat flag"

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Verified in:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d1f1f546b212ecd651146addeb328806bb270d5f
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/53e09765fe19be5f53852e793219d0af687d9795

Revert "tdf#58521 Enable ContinuousEndnotes compat option for RTF too"

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eeda1b35a6e87d5349545464da33d997c52f15e3

Revert "tdf#58521 DOCX import: enable ContinuousEndnotes compat flag"

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Reopening after the revert

*** Bug 154945 has been marked as a duplicate of this bug. ***

*** Bug 153070 has been marked as a duplicate of this bug. ***

*** Bug 156086 has been marked as a duplicate of this bug. ***