Unity

Dash - Regression: Clicking between filter label and 'All' button no longer toggles filter label

Bug #1080534 reported by Thomi Richards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
High
John Lea
Unity
Fix Released
High
Andrea Azzarone
Unity 7.0.0 "R series"
unity (Ubuntu)
Fix Released
Undecided
Andrea Azzarone

Bug Description

In the past, clicking anywhere between the filter label and the 'All' button triggered a filter group to toggle between being expanded and collapsed. This is no longer the case.

See attached image - clicking anywhere in the red box used to trigger the filter label to toggle between being expended and collapsed.

This behavior has been encoded in autopilot tests, and this bug is causing the following autopilot test to fail:

unity.tests.test_dash.DashKeyNavTests.test_bottom_up_keynav_with_filter_bar

DESIGN input needed: Was the previous behavior the correct one (in which case this is a regression), or is the new behavior correct (in which case the autopilot tests need to be updated).

Related branches

lp://staging/~azzar1/unity/fix-1080534
Marco Trevisan (Treviño): Approve
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 20 lines (+1/-2)
1 file modified
dash/FilterExpanderLabel.cpp (+1/-2)
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :
Revision history for this message
John Lea (johnlea) wrote :

@thomir; yes this is a regression that needs to be fixed.

tags: added: udp
Changed in ayatana-design:
status: New → Fix Committed
Changed in unity:
status: New → Triaged
Changed in ayatana-design:
importance: Undecided → High
Changed in unity:
importance: Undecided → High
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
summary: - Regression: Clicking between filter label and 'All' button no longer
- toggles filter label
+ Dash - Regression: Clicking between filter label and 'All' button no
+ longer toggles filter label
Andrea Azzarone (azzar1)
Changed in unity:
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity (Ubuntu):
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity:
milestone: none → 7.0.0
status: Triaged → In Progress
Changed in unity (Ubuntu):
status: New → In Progress
PS Jenkins bot (ps-jenkins)
Changed in unity:
status: In Progress → Fix Committed
Andrea Azzarone (azzar1)
Changed in unity (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 6.12.0daily12.12.05-0ubuntu1

---------------
unity (6.12.0daily12.12.05-0ubuntu1) raring; urgency=low

  [ Michael Terry ]
  * debian/control:
    - Update Vcs-Bzr
  * Automatic snapshot from revision 2905 (bootstrap)
    - Hide launcher tooltip once shortcut overlay appears (LP: #1035860)
    - Update shortcut overlay design (LP: #1049601)
    - Don't cut off shadow on launcher icon drag window (LP: #765715)
    - Provide more immediate feedback when clickong on launcher (LP: #893140)
    - Decorate spread windows in switcher (LP: #838222)
    - Make sure to initialize a variable before it can be used (LP: #1073516)
    - Fix FTBFS due to BAMF API change (LP: #1077937)
    - Run gtest during build (LP: #133637)
    - Make shopping lens test more robust (LP: #1077131)
    - Fix some random autopilot test failures (LP: #1078448)
    - Fix autopilot tests for details mode (LP: #1073892)
    - Fix autopilot tests for indicator-session (LP: #1075350)
    - Fix autopilot tests for non-English locales (LP: #1075898)

  [ Didier Roche ]
  * debian/control:
    - adding libgtest-dev and google-mock build-dep now that there are in main
      (LP: #1076763)
    - add libunity-core -> unity-common dep (LP: #1079132)
    - do not have unity-common dep on compiz-gnome: the migration code is only
      ran if compiz-gnome is installed, but compiz-gnome is pulled by compiz
      directly. We don't care if the migration code isn't executed.

  [ bschaefer ]
  * Ported to nux 4.0

  [ Ricardo Salveti de Araujo ]
  * Doesn't need to depend on gcc 4.6 anymore (LP: #1044836)

  [ Nick Dedekind ]
  * Previews loading more than 454 lines of description text crash Unity
    (LP: #1066788)

  [ Brandon Schaefer ]
  * unity::TimeUtil::TimeDelta returns an int value which overflows
    after 24 days of uptime (LP: #806248)
  * Top panel "tooltip" is gone (regression) (LP: #1085045)
  * Dash - Implement *overlay scrollbars* in Dash. Existing scrollbars
    are too thin to grab on to. (LP: #608124)

  [ Andrea Azzarone ]
  * Dash - Regression: Clicking between filter label and 'All' button no
    longer toggles filter label (LP: #1080534)

  [ Didier Roche ]
  * libunity-core fails without the schemas from unity-common (LP:
    #1079132)

  [ Manuel de la Pena ]
  * There is no common ui element that behaves like a url link (LP:
    #1067705)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 2956
 -- Automatic PS uploader <email address hidden> Wed, 05 Dec 2012 09:27:29 +0000

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Stephen M. Webb (bregma)
Changed in unity:
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in unity:
status: Fix Released → Fix Committed
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix Released in Unity Unity 7.0.0 "R series".

Changed in unity:
status: Fix Committed → Fix Released
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.