tenant dictionary passed to (SQL)Identity.create_tenant is modified
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Identity (keystone) |
Fix Released
|
Undecided
|
Ionuț Arțăriși |
Bug Description
The Tenant.to_dict method of the SQL backend adds an 'extra' key in the tenant dictionary that was passed to create_tenant.
This is apparent only when running the SQL tests before the LDAP ones:
nosetests -s tests/test_
=======
FAIL: test_authenticate (test_backend_
-------
Traceback (most recent call last):
File "/var/lib/
self.
File "/var/lib/
'Expected key %s not in %s.' % (k, actual))
AssertionError: Expected key extra not in {'id': 'bar', 'name': 'BAR'}.
-------
~~ snipped lots of LDAP logs ~~
Running them in the usual alphabetic order, doesn't show any errors (nosetests -s tests/test_
The simple fix is to pass a copy of the tenant fixture to create_tenant in the load_fixtures function. OTOH is this really the proper functionality for the Identity backend? i.e. modifying the dictionary passed in to create_tenant?
The fix is trivial for both cases, so I'd just like a second opinion on where to fix it: keystone.test vs keystone.
Changed in keystone: | |
milestone: | none → grizzly-1 |
status: | Fix Committed → Fix Released |
Changed in keystone: | |
milestone: | grizzly-1 → 2013.1 |
Fix proposed to branch: master /review. openstack. org/14472
Review: https:/