floating ip pollster should trap error from lack of ip addresses

Bug #1056087 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Unassigned

Bug Description

If the central pollster for floating ips finds none, it does not trap the error raised by the database layer.

2012-09-25 06:29:09 WARNING ceilometer.central.manager [-] Continuing after error from network_floatingip: Zero floating ips exist.

2012-09-25 06:29:09 ERROR ceilometer.central.manager [-] Zero floating ips exist.

2012-09-25 06:29:09 TRACE ceilometer.central.manager Traceback (most recent call last):

2012-09-25 06:29:09 TRACE ceilometer.central.manager File "/opt/stack/ceilometer/ceilometer/central/manager.py", line 66, in periodic_tasks

2012-09-25 06:29:09 TRACE ceilometer.central.manager for c in pollster.get_counters(self, context):

2012-09-25 06:29:09 TRACE ceilometer.central.manager File "/opt/stack/ceilometer/ceilometer/network/floatingip.py", line 33, in get_counters

2012-09-25 06:29:09 TRACE ceilometer.central.manager ips = manager.db.floating_ip_get_all(context)

2012-09-25 06:29:09 TRACE ceilometer.central.manager File "/opt/stack/nova/nova/db/api.py", line 323, in floating_ip_get_all

2012-09-25 06:29:09 TRACE ceilometer.central.manager return IMPL.floating_ip_get_all(context)

2012-09-25 06:29:09 TRACE ceilometer.central.manager File "/opt/stack/nova/nova/db/sqlalchemy/api.py", line 111, in wrapper

2012-09-25 06:29:09 TRACE ceilometer.central.manager return f(*args, **kwargs)

2012-09-25 06:29:09 TRACE ceilometer.central.manager File "/opt/stack/nova/nova/db/sqlalchemy/api.py", line 882, in floating_ip_get_all

2012-09-25 06:29:09 TRACE ceilometer.central.manager raise exception.NoFloatingIpsDefined()

2012-09-25 06:29:09 TRACE ceilometer.central.manager NoFloatingIpsDefined: Zero floating ips exist.

description: updated
Revision history for this message
John Tran (jtran) wrote :

This ticket most likely be resolved once nova db calls are replaced with nova api calls ticket :

https://review.openstack.org/#/c/14185/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/15282
Committed: http://github.com/stackforge/ceilometer/commit/f15892f229f3909dc1e3d5baa1cc5f95e172cc93
Submitter: Jenkins
Branch: master

commit f15892f229f3909dc1e3d5baa1cc5f95e172cc93
Author: John Tran <email address hidden>
Date: Fri Nov 2 16:44:42 2012 +0000

    pollster trap error due to zero floating ip

    fixes bug #1056087 when nova doesn't have any
    floating ip addresses defined causes a db
    exception instead of raising it should be
    trapped

    Change-Id: Iea441fb8bcd720339b2446525a6202941c33a1ec

Changed in ceilometer:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.