Searching with copy location search groups creates Apache error

Bug #1055481 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

Evergreen 2.3+

Selecting a copy location group from the org unit selector in the TPAC results in an Apache 500 error. The source of the error is that TPAC is using 'loc' to encode the org : location-group information. This is likely the result of commit 5ac1a89.

Here is a patch that changes the logic to always upgrade 'loc' to 'locg' instead of trying to figure out which to use where, since 'locg' is always a suitable container for the information when dealing with search param propagation.

working => user/berick/tpac-repair-locg-search

Tags: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

See also bug #1055481 for 2.2-related stuff

Revision history for this message
Dan Scott (denials) wrote :

Tested (took a while to figure out how to create a copy location group - that's a weird UI!) and confirmed that copy location group searches were broken before this patch, and fixed by this patch. It's too bad that we now have an effectively useless "loc" variable floating around in our code.

Committed to master.

Changed in evergreen:
status: New → Fix Committed
Revision history for this message
Dan Scott (denials) wrote :

Wait - this _is_ bug #1055481 ! I'll find it...

Revision history for this message
Bill Erickson (berick) wrote :

Oops, I meant to reference bug #1052021 -- which would result in the back-port of the get_library block into 2.2, at which point we'd need to backport this to 2.2

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.