Lefthand driver in san.py not setting Lun in model_update

Bug #1053717 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith
OpenStack Compute (nova)
Fix Released
High
John Griffith

Bug Description

Lun number is not being provided in the model_update of provider location. As a result the default of Lun 1 is used when exporting which is incorrect.

This needs to be specified as lun 0 as I believe LH is configured such that volumes are always created at Lun 0.

Changed in cinder:
status: New → Triaged
importance: Undecided → High
assignee: nobody → John Griffith (john-griffith)
milestone: none → folsom-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13427

Changed in cinder:
status: Triaged → In Progress
Changed in nova:
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13428

Changed in nova:
status: New → In Progress
Changed in nova:
milestone: none → folsom-rc2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/13427
Committed: http://github.com/openstack/cinder/commit/f55198570fd59b7a2a4ddd2f5e77b3d03d0a3d64
Submitter: Jenkins
Branch: master

commit f55198570fd59b7a2a4ddd2f5e77b3d03d0a3d64
Author: John Griffith <email address hidden>
Date: Thu Sep 20 17:27:13 2012 -0600

    Add lun number (0) to model_update in HpSanDriver

    The HpSanDriver was not setting the lun number in model_update
    and as a result default value of 1 was being used. Trouble is the
    Lun number used by LeftHand is 0, so the connect info would be
    wrong and fail when trying to attach the volume.

    Fixes bug #1053717

    Change-Id: If82a66c6a78ab03da09223a7b79abe559a6f702f

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13435

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (milestone-proposed)

Reviewed: https://review.openstack.org/13435
Committed: http://github.com/openstack/cinder/commit/95cae99475e7a0eb549478306f56210bb2b8a597
Submitter: Jenkins
Branch: milestone-proposed

commit 95cae99475e7a0eb549478306f56210bb2b8a597
Author: John Griffith <email address hidden>
Date: Thu Sep 20 17:27:13 2012 -0600

    Add lun number (0) to model_update in HpSanDriver

    The HpSanDriver was not setting the lun number in model_update
    and as a result default value of 1 was being used. Trouble is the
    Lun number used by LeftHand is 0, so the connect info would be
    wrong and fail when trying to attach the volume.

    Fixes bug #1053717

    Change-Id: If82a66c6a78ab03da09223a7b79abe559a6f702f
    (cherry picked from commit f55198570fd59b7a2a4ddd2f5e77b3d03d0a3d64)

Changed in cinder:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/13428
Committed: http://github.com/openstack/nova/commit/a512a57cb3a6321a337ce8fb2607b2ac577bd6d3
Submitter: Jenkins
Branch: master

commit a512a57cb3a6321a337ce8fb2607b2ac577bd6d3
Author: John Griffith <email address hidden>
Date: Thu Sep 20 17:41:37 2012 -0600

    Add lun number (0) to model_update in HpSanDriver

    The HpSanDriver was not setting the lun number in model_update
    and as a result default value of 1 was being used. Trouble is the
    Lun number used by LeftHand is 0, so the connect info would be
    wrong and fail when trying to attach the volume.

    Fixes bug #1053717

    Change-Id: I2391db062dff35365030e33c3eb0569fdd397949

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/13473
Committed: http://github.com/openstack/nova/commit/4e4c484fc4f2195a5bfb0f4f0f96362dec6ccb55
Submitter: Jenkins
Branch: milestone-proposed

commit 4e4c484fc4f2195a5bfb0f4f0f96362dec6ccb55
Author: John Griffith <email address hidden>
Date: Thu Sep 20 17:41:37 2012 -0600

    Add lun number (0) to model_update in HpSanDriver

    The HpSanDriver was not setting the lun number in model_update
    and as a result default value of 1 was being used. Trouble is the
    Lun number used by LeftHand is 0, so the connect info would be
    wrong and fail when trying to attach the volume.

    Fixes bug #1053717

    Change-Id: I2391db062dff35365030e33c3eb0569fdd397949

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: folsom-rc2 → 2012.2
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.