neutron

All subprocess.Popen calls should go through common function

Bug #1053381 reported by Thierry Carrez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Gary Kotton
neutron 2013.1 "grizzly"

Bug Description

In current Quantum there are direct subprocess.Popen calls in:

quantum/plugins/cisco/ucs/cisco_getvif.py
quantum/plugins/cisco/services/services_logistics.py
quantum/plugins/cisco/services/service_insertion.py
quantum/agent/linux/utils.py
quantum/common/utils.py

Those should all make use of a common function (probably the one in quantum/common/utils.py) so that patching for things like the SIGPIPE handler (bug 1053364) is easy and not resulting in duplication of code.

Gary Kotton (garyk)
Changed in quantum:
assignee: nobody → Gary Kotton (garyk)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13536

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/13536
Committed: http://github.com/openstack/quantum/commit/9cb3652f979a7d7a7614aa55286d0099834d604f
Submitter: Jenkins
Branch: master

commit 9cb3652f979a7d7a7614aa55286d0099834d604f
Author: Gary Kotton <email address hidden>
Date: Sun Sep 23 08:34:33 2012 +0000

    Uses a common subprocess popen function

    Fixes bug 1053381

    Change-Id: I8a89ba8d4f03094fcc581981044582c95d1300bb

Changed in quantum:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in quantum:
milestone: none → grizzly-1
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-1 → 2013.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/32922

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (stable/grizzly)

Reviewed: https://review.openstack.org/32922
Committed: http://github.com/openstack/quantum/commit/8917451b3686a1a2c1366322447bab829238cc88
Submitter: Jenkins
Branch: stable/grizzly

commit 8917451b3686a1a2c1366322447bab829238cc88
Author: Dirk Mueller <email address hidden>
Date: Thu Jun 13 18:52:37 2013 +0200

    Do not import anything from quantum into rootwrap

    The rootwrapper is special and shouldn't do heavy code
    loading, first for performance and 2nd for potential
    security issues.

    It shaves off 0.2s of load time (aka heavy cpu usage when
    using openvswitch as it invokes rootwrap twice every 4 seconds)

    Fixes LP bug 1190675

    This is reverting bug 1053381

        Author: Gary Kotton <email address hidden>
        Date: Sun Sep 23 08:34:33 2012 +0000

            Uses a common subprocess popen function

    Change-Id: I629d90aaeb99b225d716da82c6ac5c3f327ebb67

tags: added: in-stable-grizzly
Alan Pevec (apevec)
tags: removed: in-stable-grizzly
no longer affects: neutron/grizzly
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.