OpenStack Compute (nova)

scheduler rpc API needs to be updated

Bug #1052670 reported by Russell Bryant on 2012-09-18

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	High	Russell Bryant	OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

The following change modified the scheduler rpc API but did not properly update the rpc API version.

commit de09c1866b9138610914ddaaebb9b030884d1e28
Author: Unmesh Gurjar <email address hidden>
Date: Sat Aug 11 10:31:51 2012 -0700

Adds new volume API extensions

    Adds following extensions:
    1. Create volume from image
    2. Copy volume to image

Added unit tests.

Implements: blueprint create-volume-from-image

Conflicts:

        cinder/api/openstack/volume/contrib/volume_actions.py
        cinder/tests/api/openstack/fakes.py
        cinder/tests/api/openstack/volume/contrib/test_volume_actions.py
        cinder/tests/policy.json
        nova/api/openstack/volume/volumes.py
        nova/flags.py
        nova/tests/api/openstack/volume/test_volumes.py
        nova/tests/test_volume.py
        nova/utils.py
        nova/volume/api.py
        nova/volume/manager.py

    This is based on a cherry-pick of cinder commit
    2f5360753308eb8b10581fc3c026c1b66f42ebdc with bug fixes
    8c30edff982042d2533a810709308b586267c0e9 and
    ffe5036fa0e63ccde2d19aa0f425ec43de338dd7 squashed in.

Change-Id: I9c73bd3fa2fa2e0648c01ff3f4fc66f757d7bc3f

Russell Bryant (russellb) on 2012-09-18

Changed in nova:
importance:	Undecided → High
status:	New → Confirmed
assignee:	nobody → Russell Bryant (russellb)
milestone:	none → folsom-rc1

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2012-09-18:

bug link was missed:

https://review.openstack.org/#/c/13229/

Changed in nova:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-09-18: Fix merged to nova (master)

Reviewed: https://review.openstack.org/13229
Committed: http://github.com/openstack/nova/commit/fe916c95cfdaf4aeb1fdbfd57421b7d1222e7d4b
Submitter: Jenkins
Branch: master

commit fe916c95cfdaf4aeb1fdbfd57421b7d1222e7d4b
Author: Russell Bryant <email address hidden>
Date: Tue Sep 18 17:01:34 2012 -0400

Update scheduler rpc API version.

    Commit de09c1866b9138610914ddaaebb9b030884d1e28 updated the scheduler
    rpc API but did not account for rpc API versioning. This patch fixes it
    up. It updates the manager to reflect that it implements '2.1' and is
    now backwards compatible with the old method signature. The client side
    rpcapi now indicates that it requires '2.1' when sending the new
    image_id argument.

Fix bug 1052670.

Change-Id: Ide541f38d3d0129809da56baffe95bc3faab0569