OpenStack Compute (nova)

Update hyperv spawn() signature

Bug #1045392 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Mark McLoughlin
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

In nova.virt.driver:

    def spawn(self, context, instance, image_meta, injected_files,
              admin_password, network_info=None, block_device_info=None):

in nova.virt.hyperv.driver

    def spawn(self, context, instance, image_meta, network_info,
        block_device_info=None):

i.e. missing network_info and admin_password

Regression caused by https://review.openstack.org/11282

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12322

Changed in nova:
assignee: nobody → Mark McLoughlin (markmc)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/12322
Committed: http://github.com/openstack/nova/commit/241dad3e0e647c9200b46c8bc0fc4868a66483b8
Submitter: Jenkins
Branch: master

commit 241dad3e0e647c9200b46c8bc0fc4868a66483b8
Author: Mark McLoughlin <email address hidden>
Date: Mon Sep 3 16:43:37 2012 +0100

    Fix hyperv driver spawn() signature

    Fixes bug #1045392

    commit 99fb9d2a changed the signature of the spawn() method but not
    all drivers were updated for the change.

    The injected_files and admin_password instance attributes were ignored
    by the hyperv driver before, so we can just ignore them in spawn() now
    that they are being passed as function arguments.

    Change-Id: I129d21316488a18a4f062252ba5f788bc65c7c25

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.