Compiz

[FFE] Port GTK Window Decorator to GSettings

Bug #1042323 reported by Sam Spilsbury on 2012-08-27

This bug affects 11 people

	Status	Importance	Assigned to	Milestone
Compiz	Fix Released	High	Sam Spilsbury	Compiz 0.9.8.2
compiz (Ubuntu)	Fix Released	High	Unassigned	Ubuntu ubuntu-12.10-beta-2
Quantal	Fix Released	High	Unassigned	Ubuntu ubuntu-12.10-beta-2

Bug Description

We have written a compizconfig backend which uses GSettings, however gtk-window-decorator still uses GConf, so we cannot drop the gconf dep from the compiz source completely. gtk-window-decorator should also be using GSettings. Tests need to be included.

== CHANGE ==

Refactors the settings code in gtk-window-decorator to use an abstract intermediate object GWDSettings which provides the necessary interfaces for the settings storage backend to update the decorator when necessary. Provides two backends for usage - a GConf backend (based on the old code) and a GSettings Backend

== TESTING ==

Test suite included, coverage report attached to bug when complete

== WHY? ==

We want to drop the gconf dep from the compiz source package. We don't want to depend on metacity gconf keys which are being removed

== FALLBACK ==

Reintroduce metacity gconf keys, revert to gconf code

See original description

Related branches

lp://staging/~compiz-team/compiz/compiz.gtk-window-decorator-gsettings

Merged into lp://staging/compiz/0.9.8 at revision 3354

Daniel van Vugt: Approve on 2012-09-06

jenkins (community): Approve (continuous-integration) on 2012-09-05

Compiz Maintainers: Pending requested 2012-09-05

Diff: 8539 lines (+6874/-913)

48 files modified

cmake/CompizGSettings.cmake (+8/-2)
gtk/window-decorator/CMakeLists.txt (+70/-1)
gtk/window-decorator/blurprops.c (+5/-2)
gtk/window-decorator/cairo.c (+2/-2)
gtk/window-decorator/decorator.c (+17/-33)
gtk/window-decorator/events.c (+23/-10)
gtk/window-decorator/frames.c (+7/-5)
gtk/window-decorator/gtk-window-decorator.c (+52/-122)
gtk/window-decorator/gtk-window-decorator.h (+22/-65)
gtk/window-decorator/gwd-settings-interface.c (+162/-0)
gtk/window-decorator/gwd-settings-interface.h (+102/-0)
gtk/window-decorator/gwd-settings-notified-interface.c (+37/-0)
gtk/window-decorator/gwd-settings-notified-interface.h (+63/-0)
gtk/window-decorator/gwd-settings-notified.c (+264/-0)
gtk/window-decorator/gwd-settings-notified.h (+37/-0)
gtk/window-decorator/gwd-settings-storage-gconf.c (+387/-0)
gtk/window-decorator/gwd-settings-storage-gconf.h (+55/-0)
gtk/window-decorator/gwd-settings-storage-gsettings.c (+531/-0)
gtk/window-decorator/gwd-settings-storage-gsettings.h (+84/-0)
gtk/window-decorator/gwd-settings-storage-interface.c (+63/-0)
gtk/window-decorator/gwd-settings-storage-interface.h (+66/-0)
gtk/window-decorator/gwd-settings-writable-interface.c (+134/-0)
gtk/window-decorator/gwd-settings-writable-interface.h (+142/-0)
gtk/window-decorator/gwd-settings-xproperty-interface.c (+16/-0)
gtk/window-decorator/gwd-settings-xproperty-interface.h (+51/-0)
gtk/window-decorator/gwd-settings-xproperty-storage.c (+261/-0)
gtk/window-decorator/gwd-settings-xproperty-storage.h (+39/-0)
gtk/window-decorator/gwd-settings.c (+911/-0)
gtk/window-decorator/gwd-settings.h (+41/-0)
gtk/window-decorator/metacity.c (+59/-39)
gtk/window-decorator/org.compiz.gwd.gschema.xml (+47/-0)
gtk/window-decorator/settings.c (+76/-631)
gtk/window-decorator/tests/CMakeLists.txt (+114/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings.cpp (+186/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings.h (+86/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_notified.cpp (+173/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_notified.h (+70/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_storage.cpp (+192/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_storage.h (+79/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_writable.cpp (+277/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_writable.h (+107/-0)
gtk/window-decorator/tests/compiz_gwd_tests.h.in (+12/-0)
gtk/window-decorator/tests/org.gnome.desktop.wm.preferences.gschema.xml (+72/-0)
gtk/window-decorator/tests/org.gnome.mutter.gschema.xml (+18/-0)
gtk/window-decorator/tests/test_gwd_settings.cpp (+1635/-0)
gtk/window-decorator/wnck.c (+4/-1)
include/decoration.h (+4/-0)
libdecoration/decoration.c (+11/-0)

lp://staging/~compiz-team/compiz/compiz.gtk-window-decorator-gsettings.cleanup-1

Merged into lp://staging/compiz/0.9.8 at revision 3356

Sam Spilsbury: Approve on 2012-09-10

Daniel van Vugt: Pending requested 2012-09-10

jenkins: Pending (continuous-integration) requested 2012-09-10

lp://staging/~compiz-team/compiz/compiz.gtk-window-decorator.fix-metacity-cairo

Merged into lp://staging/compiz/0.9.8 at revision 3360

Daniel van Vugt: Needs Resubmitting on 2012-09-10

Sam Spilsbury: Approve on 2012-09-10

jenkins: Pending (continuous-integration) requested 2012-09-10

lp://staging/~timo-jyrinki/compiz/ubuntu.0982

Merged into lp://staging/ubuntu/quantal/compiz at revision 3292

Ubuntu branches: Pending requested 2012-09-11

Diff: 18751 lines (+12055/-2496)

268 files modified

AUTHORS (+36/-16)
CMakeLists.txt (+0/-6)
NEWS (+57/-0)
VERSION (+1/-1)
cmake/CompizCommon.cmake (+1/-1)
cmake/CompizGSettings.cmake (+8/-2)
cmake/CompizPlugin.cmake (+0/-3)
cmake/FindCompiz.cmake (+1/-4)
compizconfig/ccsm/CMakeLists.txt (+8/-10)
compizconfig/ccsm/VERSION (+0/-1)
compizconfig/ccsm/ccm/Widgets.py (+1/-1)
compizconfig/ccsm/setup.py (+31/-8)
compizconfig/cmake/exec_setup_py_with_destdir.cmake (+2/-1)
compizconfig/compizconfig-python/CMakeLists.txt (+14/-17)
compizconfig/compizconfig-python/VERSION (+0/-1)
compizconfig/compizconfig-python/compizconfig-python.pc.in (+1/-1)
compizconfig/compizconfig-python/setup.py (+29/-11)
compizconfig/compizconfig-python/src/compizconfig.pyx (+0/-30)
compizconfig/gconf/VERSION (+0/-1)
compizconfig/gsettings/VERSION (+0/-1)
compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml (+11/-11)
compizconfig/integration/gnome/include/ccs_gnome_integration_constants.h (+1/-1)
compizconfig/libcompizconfig/CMakeLists.txt (+4/-11)
compizconfig/libcompizconfig/VERSION (+0/-1)
compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake (+1/-1)
compizconfig/libcompizconfig/include/CMakeLists.txt (+1/-0)
compizconfig/libcompizconfig/src/CMakeLists.txt (+10/-1)
compizconfig/libcompizconfig/src/ccs_settings_upgrade_internal.c (+168/-0)
compizconfig/libcompizconfig/src/ccs_settings_upgrade_internal.h (+41/-0)
compizconfig/libcompizconfig/src/main.c (+184/-163)
compizconfig/libcompizconfig/tests/CMakeLists.txt (+13/-0)
compizconfig/libcompizconfig/tests/compizconfig_test_ccs_settings_upgrade_internal.cpp (+70/-0)
debian/changelog (+62/-3)
debian/compiz-dev.install (+9/-1)
debian/compiz-gnome.migrations (+1/-0)
debian/patches/100_expo_layout.patch (+2903/-0)
debian/patches/series (+1/-0)
gtk/gnome/50-compiz-launchers.xml.in (+1/-1)
gtk/window-decorator/CMakeLists.txt (+89/-20)
gtk/window-decorator/blurprops.c (+5/-2)
gtk/window-decorator/cairo.c (+2/-2)
gtk/window-decorator/decorator.c (+17/-33)
gtk/window-decorator/events.c (+23/-10)
gtk/window-decorator/frames.c (+6/-5)
gtk/window-decorator/gtk-window-decorator.c (+67/-120)
gtk/window-decorator/gtk-window-decorator.h (+35/-78)
gtk/window-decorator/gwd-settings-interface.c (+181/-0)
gtk/window-decorator/gwd-settings-interface.h (+103/-0)
gtk/window-decorator/gwd-settings-notified-interface.c (+56/-0)
gtk/window-decorator/gwd-settings-notified-interface.h (+64/-0)
gtk/window-decorator/gwd-settings-notified.c (+283/-0)
gtk/window-decorator/gwd-settings-notified.h (+38/-0)
gtk/window-decorator/gwd-settings-storage-gconf.c (+425/-0)
gtk/window-decorator/gwd-settings-storage-gconf.h (+56/-0)
gtk/window-decorator/gwd-settings-storage-gsettings.c (+567/-0)
gtk/window-decorator/gwd-settings-storage-gsettings.h (+85/-0)
gtk/window-decorator/gwd-settings-storage-interface.c (+82/-0)
gtk/window-decorator/gwd-settings-storage-interface.h (+67/-0)
gtk/window-decorator/gwd-settings-writable-interface.c (+153/-0)
gtk/window-decorator/gwd-settings-writable-interface.h (+150/-0)
gtk/window-decorator/gwd-settings-xproperty-interface.c (+35/-0)
gtk/window-decorator/gwd-settings-xproperty-interface.h (+52/-0)
gtk/window-decorator/gwd-settings-xproperty-storage.c (+296/-0)
gtk/window-decorator/gwd-settings-xproperty-storage.h (+42/-0)
gtk/window-decorator/gwd-settings.c (+934/-0)
gtk/window-decorator/gwd-settings.h (+40/-0)
gtk/window-decorator/metacity.c (+59/-39)
gtk/window-decorator/org.compiz.gwd.gschema.xml (+47/-0)
gtk/window-decorator/settings.c (+76/-631)
gtk/window-decorator/tests/CMakeLists.txt (+114/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings.cpp (+205/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings.h (+86/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_notified.cpp (+192/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_notified.h (+71/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_storage.cpp (+211/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_storage.h (+80/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_writable.cpp (+296/-0)
gtk/window-decorator/tests/compiz_gwd_mock_settings_writable.h (+108/-0)
gtk/window-decorator/tests/compiz_gwd_tests.h.in (+31/-0)
gtk/window-decorator/tests/org.gnome.desktop.wm.preferences.gschema.xml (+72/-0)
gtk/window-decorator/tests/org.gnome.mutter.gschema.xml (+18/-0)
gtk/window-decorator/tests/test_gwd_settings.cpp (+1653/-0)
gtk/window-decorator/wnck.c (+4/-1)
include/core/CMakeLists.txt (+0/-1)
include/core/screen.h (+9/-9)
include/core/serialization.h (+0/-158)
include/decoration.h (+4/-0)
kde/window-decorator-kde4/CMakeLists.txt (+6/-3)
kde/window-decorator-kde4/decorator.cpp (+11/-4)
kde/window-decorator-kde4/decorator.h (+5/-5)
kde/window-decorator-kde4/main.cpp (+1/-1)
kde/window-decorator-kde4/window.cpp (+66/-0)
kde/window-decorator-kde4/window.h (+13/-0)
libdecoration/decoration.c (+12/-1)
plugins/addhelper/VERSION (+0/-1)
plugins/addhelper/src/addhelper.cpp (+0/-23)
plugins/addhelper/src/addhelper.h (+0/-23)
plugins/animation/VERSION (+0/-1)
plugins/animation/animation.xml.in (+2/-2)
plugins/animation/include/animation/animation.h (+4/-3)
plugins/animation/include/animation/animeffect.h (+1/-1)
plugins/animation/src/animation.cpp (+27/-19)
plugins/animation/src/grid.cpp (+8/-11)
plugins/animation/src/options.cpp (+11/-4)
plugins/animation/src/private.h (+1/-1)
plugins/animationaddon/VERSION (+0/-1)
plugins/animationaddon/src/animationaddon.cpp (+3/-0)
plugins/animationaddon/src/polygon.cpp (+2/-2)
plugins/animationaddon/src/private.h (+1/-1)
plugins/annotate/src/annotate.cpp (+1/-15)
plugins/annotate/src/annotate.h (+1/-18)
plugins/bench/VERSION (+0/-1)
plugins/bench/src/bench.cpp (+2/-12)
plugins/bench/src/bench.h (+0/-2)
plugins/bicubic/VERSION (+0/-1)
plugins/blur/src/blur.cpp (+7/-1)
plugins/blur/src/blur.h (+4/-4)
plugins/ccp/src/ccp.cpp (+2/-2)
plugins/colorfilter/VERSION (+0/-1)
plugins/colorfilter/src/colorfilter.cpp (+0/-10)
plugins/colorfilter/src/colorfilter.h (+0/-20)
plugins/commands/commands.xml.in (+63/-63)
plugins/compiztoolbox/CMakeLists.txt (+1/-1)
plugins/compiztoolbox/include/compiztoolbox/compiztoolbox.h (+2/-2)
plugins/compiztoolbox/src/compiztoolbox.cpp (+3/-0)
plugins/copytex/src/copytex.cpp (+3/-0)
plugins/copytex/src/copytex.h (+2/-2)
plugins/crashhandler/VERSION (+0/-1)
plugins/cubeaddon/VERSION (+0/-1)
plugins/cubeaddon/src/cubeaddon.cpp (+10/-0)
plugins/cubeaddon/src/cubeaddon.h (+9/-9)
plugins/dbus/src/dbus.h (+4/-4)
plugins/decor/src/decor.h (+3/-3)
plugins/expo/VERSION (+0/-1)
plugins/expo/src/expo.cpp (+1/-1)
plugins/extrawm/VERSION (+0/-1)
plugins/ezoom/VERSION (+0/-1)
plugins/ezoom/src/ezoom.cpp (+0/-29)
plugins/ezoom/src/ezoom.h (+0/-32)
plugins/fadedesktop/VERSION (+0/-1)
plugins/firepaint/VERSION (+0/-1)
plugins/firepaint/src/firepaint.cpp (+2/-43)
plugins/firepaint/src/firepaint.h (+1/-67)
plugins/gears/VERSION (+0/-1)
plugins/grid/VERSION (+0/-1)
plugins/grid/src/grid.h (+1/-1)
plugins/group/VERSION (+0/-1)
plugins/group/src/glow.cpp (+10/-0)
plugins/group/src/glow.h (+9/-9)
plugins/group/src/group.cpp (+3/-1)
plugins/group/src/group.h (+2/-25)
plugins/group/src/init.cpp (+0/-71)
plugins/group/src/tab.cpp (+1/-1)
plugins/imgjpeg/VERSION (+0/-1)
plugins/imgpng/src/imgpng.cpp (+2/-0)
plugins/imgpng/src/imgpng.h (+1/-1)
plugins/imgsvg/CMakeLists.txt (+1/-1)
plugins/kdecompat/VERSION (+0/-1)
plugins/loginout/VERSION (+0/-1)
plugins/mag/VERSION (+0/-1)
plugins/mag/src/mag.cpp (+0/-16)
plugins/mag/src/mag.h (+0/-14)
plugins/maximumize/VERSION (+0/-1)
plugins/maximumize/src/maximumize.cpp (+4/-0)
plugins/maximumize/src/maximumize.h (+3/-3)
plugins/mblur/VERSION (+0/-1)
plugins/mblur/src/mblur.cpp (+0/-10)
plugins/mblur/src/mblur.h (+0/-10)
plugins/mousepoll/VERSION (+0/-1)
plugins/mousepoll/src/mousepoll.cpp (+3/-0)
plugins/mousepoll/src/private.h (+2/-2)
plugins/move/src/move.cpp (+5/-0)
plugins/move/src/move.h (+3/-3)
plugins/neg/VERSION (+0/-1)
plugins/neg/src/neg.cpp (+0/-16)
plugins/neg/src/neg.h (+0/-11)
plugins/notification/src/notification.cpp (+3/-1)
plugins/notification/src/notification.h (+1/-1)
plugins/obs/src/obs.cpp (+4/-13)
plugins/obs/src/obs.h (+5/-15)
plugins/opacify/VERSION (+0/-1)
plugins/opacify/src/opacify.cpp (+2/-12)
plugins/opacify/src/opacify.h (+1/-12)
plugins/opengl/CMakeLists.txt (+6/-3)
plugins/opengl/DRIVERS (+54/-0)
plugins/opengl/include/opengl/opengl.h (+7/-7)
plugins/opengl/src/fsregion/CMakeLists.txt (+7/-0)
plugins/opengl/src/fsregion/fsregion.cpp (+54/-0)
plugins/opengl/src/fsregion/fsregion.h (+57/-0)
plugins/opengl/src/fsregion/tests/CMakeLists.txt (+10/-0)
plugins/opengl/src/fsregion/tests/test-fsregion.cpp (+140/-0)
plugins/opengl/src/opengl.cpp (+10/-0)
plugins/opengl/src/paint.cpp (+46/-23)
plugins/opengl/src/programcache.cpp (+2/-2)
plugins/opengl/src/vertexbuffer.cpp (+2/-2)
plugins/place/src/place.cpp (+12/-9)
plugins/place/src/smart/src/smart.cpp (+3/-3)
plugins/put/VERSION (+0/-1)
plugins/put/src/put.cpp (+4/-4)
plugins/reflex/VERSION (+0/-1)
plugins/resize/src/logic/include/resize-defs.h (+2/-2)
plugins/resize/src/logic/src/resize-logic.cpp (+7/-4)
plugins/resize/src/logic/tests/test-logic.cpp (+52/-0)
plugins/resizeinfo/VERSION (+0/-1)
plugins/resizeinfo/src/resizeinfo.cpp (+5/-0)
plugins/resizeinfo/src/resizeinfo.h (+3/-3)
plugins/ring/VERSION (+0/-1)
plugins/ring/src/ring.cpp (+4/-0)
plugins/ring/src/ring.h (+2/-2)
plugins/rotate/src/rotate.cpp (+1/-1)
plugins/scaleaddon/VERSION (+0/-1)
plugins/scaleaddon/src/scaleaddon.cpp (+1/-1)
plugins/scalefilter/VERSION (+0/-1)
plugins/session/VERSION (+0/-1)
plugins/shelf/VERSION (+0/-1)
plugins/shelf/src/shelf.cpp (+2/-0)
plugins/shelf/src/shelf.h (+1/-1)
plugins/shift/VERSION (+0/-1)
plugins/shift/src/shift.cpp (+2/-0)
plugins/shift/src/shift.h (+1/-1)
plugins/showdesktop/VERSION (+0/-1)
plugins/showdesktop/src/showdesktop.cpp (+5/-0)
plugins/showdesktop/src/showdesktop.h (+4/-4)
plugins/showmouse/VERSION (+0/-1)
plugins/showmouse/src/showmouse.cpp (+0/-40)
plugins/showmouse/src/showmouse.h (+0/-51)
plugins/showrepaint/VERSION (+0/-1)
plugins/showrepaint/src/showrepaint.cpp (+0/-8)
plugins/showrepaint/src/showrepaint.h (+0/-12)
plugins/snap/VERSION (+0/-1)
plugins/splash/VERSION (+0/-1)
plugins/splash/src/splash.cpp (+3/-0)
plugins/splash/src/splash.h (+2/-2)
plugins/stackswitch/VERSION (+0/-1)
plugins/staticswitcher/VERSION (+0/-1)
plugins/staticswitcher/src/staticswitcher.cpp (+3/-0)
plugins/staticswitcher/src/staticswitcher.h (+2/-2)
plugins/switcher/src/switcher.cpp (+6/-0)
plugins/switcher/src/switcher.h (+4/-4)
plugins/td/VERSION (+0/-1)
plugins/td/src/3d.cpp (+2/-0)
plugins/td/src/3d.h (+1/-1)
plugins/text/VERSION (+0/-1)
plugins/text/src/text.cpp (+1/-1)
plugins/thumbnail/VERSION (+0/-1)
plugins/thumbnail/src/thumbnail.cpp (+2/-0)
plugins/thumbnail/src/thumbnail.h (+1/-1)
plugins/titleinfo/VERSION (+0/-1)
plugins/trailfocus/VERSION (+0/-1)
plugins/trip/VERSION (+0/-1)
plugins/vpswitch/VERSION (+0/-1)
plugins/wall/VERSION (+0/-1)
plugins/wall/src/wall.cpp (+4/-4)
plugins/wallpaper/VERSION (+0/-1)
plugins/water/src/water.cpp (+5/-1)
plugins/water/src/water.h (+2/-2)
plugins/widget/VERSION (+0/-1)
plugins/winrules/VERSION (+0/-1)
plugins/wobbly/src/wobbly.h (+1/-1)
plugins/workarounds/VERSION (+0/-1)
postinst/convert-files/compiz-profile-Default.convert (+0/-60)
postinst/convert-files/compiz-profile-active-Default.convert (+0/-60)
postinst/convert-files/compiz-profile-independent-keys.convert (+59/-0)
postinst/migration-scripts/03_migrate_profile_independent.py (+44/-0)
src/event.cpp (+3/-3)
src/screen.cpp (+5/-5)
src/timer/src/timer.cpp (+1/-1)
tests/manual/Unredirect.txt (+77/-0)

Sam Spilsbury (smspillaz) on 2012-08-27

Changed in compiz:
status:	New → Confirmed
importance:	Undecided → High
assignee:	nobody → Sam Spilsbury (smspillaz)
milestone:	none → 0.9.8.2
description:	updated

Sam Spilsbury (smspillaz) on 2012-08-27

summary:

- Port GTK Window Decorator to GSettings
+ [FFE] Port GTK Window Decorator to GSettings

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-08-28:

Coverage: http://people.canonical.com/~smspillaz/coveragereports/compiz.gtk-window-decorator-gsettings/

Revision history for this message

Andrew Gunnerson (cxl) wrote on 2012-09-02:

From the CMakeLists.txt files, support for metacity themes seems to be optional, but gtk-window-decorator fails to build when USE_METACITY is undefined (ie. when metacity headers are not installed or if support is explicitly disabled).

Here's the build log (built with CMAKE_VERBOSE_MAKEFILE so the errors are visible): http://ompldr.org/vZmM4OQ/compiz-build.log

Revision history for this message

Andrew Gunnerson (cxl) wrote on 2012-09-03:

By the way, gtk-window-decorator links with libgtk_window_decorator_settings_notified_interface.so, which doesn't get installed.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-09-05:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in compiz (Ubuntu):
status:	New → Confirmed

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-09-05:

Hi cxl.

I've linked branches that fix the issues you describe. Thanks for pointing them out. As for the .so linking issue - I explicitly don't use shared libraries in this part of the code - everything is static and linked directly into gtk-window-decorator. Can you explain in more detail what's not installed and why that's an issue?

Revision history for this message

Dave Walker (davewalker) wrote on 2012-09-06:

Release Team ACK

Discussed with the desktop team, and this seems to be a wanted feature. If this could land shortly after beta release, it would be better.

Thanks.

Stefano Rivera (stefanor) on 2012-09-06

Changed in compiz (Ubuntu):
status:	Confirmed → Triaged

Sam Spilsbury (smspillaz) on 2012-09-10

Changed in compiz:
milestone:	0.9.8.2 → 0.9.8.4

Daniel van Vugt (vanvugt) on 2012-09-10

Changed in compiz:
milestone:	0.9.8.4 → 0.9.8.2
status:	Confirmed → In Progress

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-09-10:

Fix committed into lp:compiz at revision 3360

Changed in compiz:
status:	In Progress → Fix Committed

Daniel van Vugt (vanvugt) on 2012-09-10

Changed in compiz:
status:	Fix Committed → Fix Released

Revision history for this message

Andrew Gunnerson (cxl) wrote on 2012-09-12:

Hi Sam,

Thanks for the reply! You were right about the shared library. I'm actually packaging for Fedora, which builds with "-DBUILD_SHARED_LIBS:BOOL=ON" by default. When I build compiz manually, all is fine.

My fault, sorry :)

Kate Stewart (kate.stewart) on 2012-09-17

Changed in compiz (Ubuntu):
importance:	Undecided → High
milestone:	none → ubuntu-12.10-beta-2

Revision history for this message

Kate Stewart (kate.stewart) wrote on 2012-09-19:

Please confirm that this will make it into beta 2, otherwise FFE will need to be revisited.

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-09-19:

#10

This appears to be in the latest packaging branch:

https://code.launchpad.net/~ubuntu-branches/ubuntu/quantal/compiz/quantal
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/compiz/quantal/revision/3289

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-09-21:

#11

Download full text (5.2 KiB)

This bug was fixed in the package compiz - 1:0.9.8.2+bzr3377-0ubuntu1

---------------
compiz (1:0.9.8.2+bzr3377-0ubuntu1) quantal-proposed; urgency=low

  [ Sam Spilsbury ]
  * debian/python-compizconfig.install
    - Install compizconfig-python.pc
  * debian/patches/100_expo_layout.patch
    - re-add the expo layout that used to be in precise (LP: #1047067)
    - add some testcases

This bug was fixed in the package compiz - 1:0.9.8.2+bzr3377-0ubuntu1

---------------
compiz (1:0.9.8.2+bzr3377-0ubuntu1) quantal-proposed; urgency=low

[ Timo Jyrinki ]
  * New upstream snapshot.
    - Fix multiple window placement bugs (LP: #974242) (LP: #976032)
    - Don't waste CPU looping through and looking at all the windows if you're
      rendering an output that has no damage on it. (LP: #1014986)
    - Updated convert files to fix some typos in the key names. (LP: #1041631)
    - Fix crash when imgsvg is loaded, due to missing symbol
      (decor_apply_gravity from libdecoration). (LP: #956986)
    - Treat unresolved symbols at link time as an error, rather than letting
      them through and cause strange crashes later. (LP: #1043143)
    - Refactors a little bit of the upgrade code and gets it under test to
      prepare to fix (LP: #1042537)
    - Updated AUTHORS from the full bzr log, and re-sort the list.
      (LP: #1042095)
    - Fixes FTBFS for kde4-window-decorator (LP: #1041310)
    - Fix obvious omissions from the introduction of unminimize_*,
      which were causing the unminimize animation settings to be ignored
      (LP: #1040455)
    - resize plugin: don't crash if resize wasn't initiated externally
      (LP: #1045191)
    - Clean up capitalization (LP: #1045652)
    - Avoid division by zero, if plugins try to deform a window down to size
      zero. (LP: #1045235)
    - Make "Unredirect Fullscreen Windows" more reliable. This fixes the
      problem with unredirection failing to engage at all (LP: #1041066) when
      gtk-window-decorator creates offscreen windows that are stacked on top.
      This also fixes the problem with unredirect hiding all windows,
      because it thinks the desktop window should be stacked on top
      (LP: #980663).
    - Ensure unredirected windows don't stay unredirected if they're no longer
      on top. (LP: #1041047)
    - Fix launching terminal functionality and make show-hud default key
      visible. Update the defaults to org.compiz.integrated to reflect the
      actual gnome values pre-gnome-3. (LP: #1040081) (LP: #1046199)
      (LP: #1046190)
    - Fix show-hud, bump COMPIZ_GNOME_INTEGRATED_SETTINGS_LIST_SIZE.
      (LP: #1046212)
    - Fixed: Windows with an alpha-channel, like gnome-terminal, were not
      being considered as possibly covering fullscreen windows. But they most
      certainly can. This ensures such RGBA windows are visible if they're
      stacked above a fullscreen window. (LP: #1046661)
    - Remove ListToStringList (LP: #1046184)
    - Fix typo causing CMake Error (LP: #1045665)
    - Transitions gtk-window-decorator over to use GSettings. Add a testing
      framework for the options code. (LP: #1042323)
    - Also need kdeworkspace since kdecorationbridge.h is there
      (LP: #1046770)
    - Implements some cleanup that was suggested on the merge for the original
      port to gsettings. Other issues fixed as well. (LP: #1042323)
    - Fix the case where a new gsettings schema got added for building but
      it wasn't recompiled locally (LP: #1046701)
    - Scale: select the window under the pointer, when the scale animation
      is over. (LP: #1045127)
    - Fixes the some "Use of uninitialised value" warnings reported by
      valgrind (LP: #1004336))
    - Check if org.gnome.mutter is available before using it (LP: #1048551)
    - We don't need to map our style windows, prevent them from cluttering
      up the paint queue (LP: #1042552)
    - Migrate profile independent keys separately from the profile
      dependent keys (LP: #1046190)
    - Don't ever enter the subdir of a plugin that is disabled. (LP: #1049100)
    - Workaround SubBuffer performance regression (LP: #1037411)
    - Changed the default placement of the benchmark window from 0,0 to
      100,50. (LP: #1039406)
    - Ensure window decorations always get rendered after the window, not
      before. This is how it was in compiz 0.9.7, and is required in order
      to resolve unity panel shadow (LP: #1050704)
    - Fix CMakeLists.txt to bring an xslt file back to compiz-dev
    - Avoid a NULL dereference and give a useful error message instead
      (LP: #944653)
    - Fix (LP: #1050752)
    - Check that pixmaps which aren't managed by us actually exist before
      binding. (LP: #927168)
    - Fix flickering and performance problems with using Unredirect Fullscreen
      Windows with multiple monitors. (LP: #1050749) (LP: #1051885)
  * debian/compiz-dev.install
    - Remove compizconfig-python.pc, now in python-compizconfig.install
  * Drop dependency on libgconf2-dev, add gconf2 dependency to the
    transitional package for migrations
  * Add -DUSE_GCONF=OFF to debian/rules
  * debian/libdecoration0.symbols
    - Add decor_shadow_options_cmp
  * Cherry-pick fixes from trunk:
    - Fix FTBFS with BUILD_GLES
  * Restore 'Glide 2' unminimize animation via override

[ Didier Roche ]
  * debian/libdecoration0.symbols:
    - update the symbols file
  * add and cherry-pick missing ABI breakage bump
 -- Didier Roche <didrocks@ubuntu.com>   Thu, 20 Sep 2012 17:39:05 +0200

Changed in compiz (Ubuntu Quantal):
status:	Triaged → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.