OpenStack Compute (nova)

live migration fails with wrong number of arguments

Bug #1036449 reported by Renuka Apte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Renuka Apte
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

The following change: https://review.openstack.org/#/c/11299/ does not seem to work. By not passing in topic, the topic is mistakenly assumed to be scheduler when it should be compute for live migration.

As a result the call fails at the scheduler complaining about a wrong number of arguments.

Fixed by reverting ccac8614279d9511e8571933db425b6de112c49c and adding topic=FLAGS.compute_topic back to self.scheduler_rpcapi.live_migration in nova/compute/api.py
It appears as if the topic argument was intentionally removed, so it is unclear how this should be fixed in that case.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11316

Changed in nova:
assignee: nobody → Renuka Apte (renukaapte)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11316
Committed: http://github.com/openstack/nova/commit/7af16893514bd27be51cf5e425679ddcce07688a
Submitter: Jenkins
Branch: master

commit 7af16893514bd27be51cf5e425679ddcce07688a
Author: Renuka Apte <email address hidden>
Date: Mon Aug 13 17:29:23 2012 -0700

    Fix rpc error with live_migration

    Revert "Fix rpc error with live_migration."

    This reverts commit f72f3498656e8b4857001a1f3d194305245d56ba.

    Add missing topic argument topic=FLAGS.compute_topic, to
    nova/compute/api.py

    Fixes bug 1036449

    Change-Id: I11b77da60c8f8aa28748f8968380bca5b7b80e73

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.